Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Content page component design fixes #1172

Merged
merged 9 commits into from
Mar 24, 2022
Merged

Content page component design fixes #1172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
00d1fa4
Init
zackkrida Mar 9, 2022
6dfce00
Update translation file
zackkrida Mar 9, 2022
10dfc3e
Merge branch 'main' into content-page-component-design-fixes
obulat Mar 23, 2022
e2efc97
Apply suggestions from code review
obulat Mar 23, 2022
c2149aa
Update src/components/VContentPage.vue
obulat Mar 23, 2022
6f3ef68
Add changes from code review
obulat Mar 23, 2022
3a7ece2
Apply suggestions from code review
obulat Mar 23, 2022
0346c9e
Make VContentPage use TS
obulat Mar 23, 2022
4c51fad
Merge branch 'main' into content-page-component-design-fixes
obulat Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
"@pinia/nuxt": "^0.1.8",
"@popperjs/core": "^2.11.2",
"@tailwindcss/line-clamp": "^0.3.1",
"@tailwindcss/typography": "^0.5.2",
sarayourfriend marked this conversation as resolved.
Show resolved Hide resolved
"@wordpress/is-shallow-equal": "^4.3.1",
"axios": "^0.26.1",
"axios-mock-adapter": "^1.20.0",
Expand Down
21 changes: 21 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/components/VButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ export default VButton
}

a.button {
@apply no-underline;
@apply no-underline hover:no-underline;
}

.primary {
Expand Down
17 changes: 17 additions & 0 deletions src/components/VContentPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<template>
<div class="pt-5 md:pt-10" dir="ltr">
<div
class="px-6 lg:px-0 mb-10 lg:mb-30 md:max-w-4xl xl:max-w-5xl prose prose-sm md:prose-base mx-auto max-w-none prose-headings:font-bold lg:prose-headings:text-3xl prose-h1:text-4xl prose-h1:text-bold lg:prose-h1:text-6xl md:prose-h1:mb-10 prose-h3:text-2xl prose-h3:font-semibold md:prose-h3:mt-10"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This massive list of prose-* classes also scares me. It has all the features of the worst parts of Tailwind IMO (namely, a super long and inscrutable list of class names that are difficult to edit, read, and get a full picture of).

Adding our own prose class to tailwind.css with these styles using the @apply rule would probably be easier to read and maintain 🤷 Just my own feeling about this plugin though.

>
<slot default />
</div>
</div>
</template>

<script lang="ts">
import { defineComponent } from '@nuxtjs/composition-api'

export default defineComponent({
name: 'VContentPage',
})
</script>
Loading