Dev doc preview should only be run on maintainer PRs

[AetherUnbound]

Description

We ran into an issue in #690 wherein the docs preview failed to run because the PR was opened from a fork. The easiest way to address this is to prevent the docs preview action from running on forks.

Additional context

Resolution

• 🙋 I would be interested in resolving this bug.

[AetherUnbound]

I rebased #648 onto main, which includes the change from #693, but the docs preview still ran (and failed) on the fork PR.

[AetherUnbound]

I believe this has been addressed with #750

[AetherUnbound]

Unfortunately this is still an issue 😞 See #767

[sarayourfriend]

Is it because we're checking that the event is a pull_request? Isn't that check redundant to the configuration of the workflow itself? Based on the advice given the GitHub support forums it seems like just checking that the repository name is WordPress/openverse* should be enough (though that thread says nothing of dependabot).

[dhruvkb]

Maybe we can do something like this that we did in the frontend?

https://github.com/WordPress/openverse-frontend/blob/8d25b47bcecdb115e7d17a4743f1e3d6a1a41ac3/.github/workflows/ghcr.yml#L15

[sarayourfriend]

I wonder why the recommended approach doesn't work though?

[dhruvkb]

@sarayourfriend from my understanding, the support forum question was to prevent GitHub Actions defined in the upstream from running on a fork. But when a PR from the fork is made to the upstream repo, the PRs are running in the upstream context so the condition evaluates to true. In such a case we need to check if the PR head is also part of the upstream repo (as we did in the frontend).

[sarayourfriend]

I see! Thanks for explaining. It's strange that the way to do this is so obtuse 🤔