Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add 3D model type to constants #690

Merged
merged 3 commits into from
May 11, 2022
Merged

Conversation

foroveralls
Copy link
Contributor

Fixes

Fixes #[#658] by @[AetherUnbound]

Description

This PR updates the file media_types.py by adding the media type "3D Model" to the list of possible media types to allow the ingestion server to perform data refreshes for that media type.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@foroveralls foroveralls requested a review from a team as a code owner May 10, 2022 13:29
@openverse-bot openverse-bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label May 10, 2022
@foroveralls foroveralls requested a review from dhruvkb May 10, 2022 15:16
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have one action failing due to an unrelated issue - this looks good, thanks for the contribution @foroveralls!

@sarayourfriend
Copy link
Contributor

Will merging this now allow ingestion to work before there are 3d models to ingest?

@dhruvkb
Copy link
Member

dhruvkb commented May 11, 2022

@sarayourfriend yes, adding this should not impact ingestion. The passing CI gives me confidence that everything that works now remains functional after this change.

@dhruvkb dhruvkb changed the title 3d Model type added to media_types.py Add 3D model type to constants May 11, 2022
@dhruvkb dhruvkb merged commit 8f8eb84 into WordPress:main May 11, 2022
@foroveralls foroveralls deleted the add_3d_Models branch May 14, 2022 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants