Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Ensure that the docs cleanup step only runs on PRs that have permission #750

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

AetherUnbound
Copy link
Contributor

Description

Follow up on #747, additionally for the action that runs when a PR is closed. This was failing for the dependabot PRs: [1] [2] [3]

Testing Instructions

We'll have to see! It worked for the publish step though so I suspect it should work for the close PR step 🙂

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound AetherUnbound requested a review from a team as a code owner June 10, 2022 01:15
@AetherUnbound AetherUnbound requested review from dhruvkb and stacimc June 10, 2022 01:15
@AetherUnbound AetherUnbound added 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🤖 aspect: dx Concerns developers' experience with the codebase labels Jun 10, 2022
@github-actions
Copy link

github-actions bot commented Jun 10, 2022

API Developer Docs Preview: Ready

https://wordpress.github.io/openverse-api/_preview/750

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

Copy link
Contributor

@stacimc stacimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, lgtm. I suspect the ingestion server tests should be fine with a re-run.

Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we had a clearer picture of everything that won't run on forks and other nebulous PRs that can't support certain things 🤔

@AetherUnbound
Copy link
Contributor Author

I wish we had a clearer picture of everything that won't run on forks and other nebulous PRs that can't support certain things thinking

Hard agree! I initially tried to set the value of the expression to a variable to be used in multiple steps, but then I realized the steps were in entirely different workflows 🤦🏼‍♀️ There might be a way to "include" it from another file, but I didn't look that deeply into it.

@AetherUnbound AetherUnbound merged commit 267decf into main Jun 10, 2022
@AetherUnbound AetherUnbound deleted the bugfix/gha-docs-preview branch June 10, 2022 19:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants