Set prefer-dedupe as the default.
#61630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.75 MB ℹ️ View Unchanged
|
sirreal
approved these changes
May 13, 2024
|
I noticed Core doesn't have this, shall we set it there as well @desrosj? https://github.com/WordPress/wordpress-develop/blob/trunk/.npmrc |
sirreal
added a commit
to sirreal/wordpress-develop
that referenced
this pull request
Oct 8, 2024
This change was applied in Gutenberg: WordPress/gutenberg#61630 Quoting that : > The `npm dedupe` command searches > and attempts to simplify the overall structure of the local package > tree to allow dependent packages to be shared more effectively. As > detailed in #61532, reducing the amount of dependency duplication is > beneficial for a few reasons: > > - Fewer packages overall. > - Faster installation. > - Less size to transfer and store on disk. > - Usually bundle size is reduced (although this depends on which > versions of packages are used). > > However, unless the command is run regularly, the project's dependency > tree easily falls out of order. See https://docs.npmjs.com/cli/v10/commands/npm-dedupe
|
I created WordPress/wordpress-develop#7537 to add the config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This sets
prefer-dedupetotruein the.npmrcfile.See discussions in #61486 and #61532.
Why?
The
npm dedupecommand searches and attempts to simplify the overall structure of the local package tree to allow dependent packages to be shared more effectively. As detailed in #61532, reducing the amount of dependency duplication is beneficial for a few reasons:However, unless the command is run regularly, the project's dependency tree easily falls out of order.
How?
By configuring
prefer-dedupe, npm should avoid duplication as much as possible by default.This also includes one more
npm deduperun. In my testing, adding the value to the.npmrcdid not retroactively apply the policy (unless I've not correctly configured the setting here).