Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: Set prefer-dedupe true in npm configuration #7537

Closed

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Oct 8, 2024

This change was applied in Gutenberg:

WordPress/gutenberg#61630

Quoting that PR:

The npm dedupe command searches
and attempts to simplify the overall structure of the local package
tree to allow dependent packages to be shared more effectively. As
detailed in #61532, reducing the amount of dependency duplication is
beneficial for a few reasons:

  • Fewer packages overall.
  • Faster installation.
  • Less size to transfer and store on disk.
  • Usually bundle size is reduced (although this depends on which
    versions of packages are used).

However, unless the command is run regularly, the project's dependency
tree easily falls out of order.

See https://docs.npmjs.com/cli/v10/commands/npm-dedupe

Trac ticket: https://core.trac.wordpress.org/ticket/62190


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

This change was applied in Gutenberg:

WordPress/gutenberg#61630

Quoting that :

> The `npm dedupe` command searches
> and attempts to simplify the overall structure of the local package
> tree to allow dependent packages to be shared more effectively. As
> detailed in #61532, reducing the amount of dependency duplication is
> beneficial for a few reasons:
>
> - Fewer packages overall.
> - Faster installation.
> - Less size to transfer and store on disk.
> - Usually bundle size is reduced (although this depends on which
>   versions of packages are used).
>
> However, unless the command is run regularly, the project's dependency
> tree easily falls out of order.

See https://docs.npmjs.com/cli/v10/commands/npm-dedupe
Copy link

github-actions bot commented Oct 8, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jonsurrell, desrosj.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Oct 8, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@sirreal
Copy link
Member Author

sirreal commented Oct 8, 2024

I've created another PR that performs npm dedupe: #7538

@desrosj
Copy link
Contributor

desrosj commented Oct 10, 2024

Let's merge this change into #7538. I think it's fine to handle in the same commit!

@sirreal
Copy link
Member Author

sirreal commented Oct 10, 2024

Sounds good, now that #7526 has landed there shouldn't be any conflicts 👍

@sirreal
Copy link
Member Author

sirreal commented Oct 10, 2024

Superseded by #7538.

@sirreal sirreal closed this Oct 10, 2024
@sirreal sirreal deleted the dependencies/npm-set-prefer-dedupe branch October 10, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants