Update npm lockfile to version 3 #65923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> 3: Only the new lockfile information introduced in npm version 7. > Smaller on disk than lockfile version 2, but not interoperable with > older npm versions. Ideal if all users are on npm version 7 and > higher. https://docs.npmjs.com/cli/v8/using-npm/config#lockfile-version
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I created a PR for Core as well: WordPress/wordpress-develop#7526 |
|
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
|
Assuming CI passes, it should be fine to upgrade the lock file 👍 |
DaniGuardiola
approved these changes
Oct 7, 2024
|
Thank you @sirreal 🚀 |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Set the npm lockfile version to 3. > 3: Only the new lockfile information introduced in npm version 7. > Smaller on disk than lockfile version 2, but not interoperable with > older npm versions. Ideal if all users are on npm version 7 and > higher. https://docs.npmjs.com/cli/v8/using-npm/config#lockfile-version Given the engines and engine-strict setting, npm should always be later than version 7. There should be no downsides to this change. --- Co-authored-by: sirreal <jonsurrell@git.wordpress.org> Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update the package-lock.json file to the v3 format:
Given our engines and engine-strict setting, npm versions earlier than 7 should not be used and there should be no downsides to this change:
gutenberg/package.json
Lines 17 to 20 in 3214be4
gutenberg/.npmrc
Line 2 in 3214be4
Why?
The file should be smaller without other changes. It should be strictly better.
The package-lock.json file goes from
3475383to1926901bytes in this PR, a savings of ~1.5MB.How?
Testing Instructions
CI should pass on the PR. Locally the project should work without any changes:
npm ci,npm run build, etc.