[Mobile] Update toolbar icons and colors #52336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
[Status] In Progress
|
Size Change: +1.26 kB (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
geriux
added
the
Mobile App - Automation
added 10 commits
July 7, 2023 18:48
# Conflicts: # packages/edit-post/src/components/header/header-toolbar/index.native.js
# Conflicts: # packages/edit-post/src/components/header/header-toolbar/index.native.js
geriux
removed
the
Mobile App - Automation
|
Flaky tests detected in 98eb51c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5543063869
|
fluiddot
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
LGTM 🎊 ! Awesome work @geriux 🏅 !
I confirmed that all UI updates look as expected based on the PR's description. I added a couple of minor comments, feel free to skip them.
Tested on Simulator - iPhone 14 (iOS 16.4) and Samsung Galaxy S20 FE 5G (Android 13).
packages/edit-post/src/components/header/header-toolbar/index.native.js
Outdated
Show resolved
Hide resolved
westonruter
added a commit
that referenced
this pull request
Jul 18, 2023
* trunk: (36 commits) Use `_get_block_template_file` function and set $area variable. (#52708) Change Delete page menu item to Move to trash. (#52641) Search block: Enqueue view script through block.json (#52552) Patterns: fix bug with Create Patterns menu not showing in site editor page editing (#52671) Github workflow: add a PHP backport changes action (#52096) Add layout API documentation. (#52673) Show uncategorized patterns on the Editor > Patterns page (#52633) Patterns: Remove `reusable` text from menu once rename hint has been dismissed (#52664) Update locked pattern tooltips (#52497) Rich Text/Footnotes: fix getRichTextValues for useInnerBlocksProps.save (#52682) Use posts instead of template parts for navigation color tests (#52654) Site Editor: Don't allow creating template part on the Patterns page for non-block themes (#52656) Site Editor: Fix incorrect 'useSelect' usage (#52683) Update issue gardening automation with new label (#52173) i18n: Make the tab labels of `ColorGradientSettingsDropdown` component translatable (#52669) Post Content link color should not be applied to placeholder component links (#52367) [Mobile] Update toolbar icons and colors (#52336) Avoid copying global style presets via the styles compatibility hook (#52640) Show warning on removal of Post Template block in the site editor. (#52666) Backport tools: sort PRs to be cherry picked by merged/closed date (#52667) ...
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
What?
This PR updates the current colors for the toolbar icons, the toolbar itself, and the safe area background.
Why?
It's part of the improvements for the mobile editor's UI.
How?
_colors.native.scssfile for the updates$app-safe-area-backgroundfor the SafeAreaTesting Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast