Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] Update toolbar icons and colors #5940

Conversation

wpmobilebot
Copy link
Collaborator

@wpmobilebot wpmobilebot commented Jul 5, 2023

Related PRs

Description

This PR updates the current colors for the toolbar icons, the toolbar itself, and the safe area background.

For a better PR description and testing steps please check the Gutenberg PR linked above.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 5, 2023

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@geriux geriux force-pushed the version-toolkit/gutenberg/rnmobile/update-mobile-toolbar-icons-and-color branch from 3b868ed to bbd3482 Compare July 13, 2023 12:11
@geriux geriux requested a review from fluiddot July 17, 2023 10:10
@geriux
Copy link
Contributor

geriux commented Jul 17, 2023

Hey @fluiddot 👋 I was wondering if you could also review this PR! Let me know, thanks!

@geriux geriux added this to the 1.100.0 (22.9) milestone Jul 17, 2023
@fluiddot
Copy link
Contributor

Hey @fluiddot 👋 I was wondering if you could also review this PR! Let me know, thanks!

Sure thing, I'm taking a look right now.

Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#52336 (review).

I checked the screenshot updates and confirmed that the toolbar is displayed with the new styles. I noticed that a couple of them were updated but couldn't find a real difference, I assume this is a minor issue as the new version looks as expected.

@geriux geriux merged commit 38ce881 into trunk Jul 17, 2023
@geriux geriux deleted the version-toolkit/gutenberg/rnmobile/update-mobile-toolbar-icons-and-color branch July 17, 2023 13:14
This was referenced Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants