[Mobile] Moves block settings and more button to the toolbar #52289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
July 4, 2023 18:40
…ock, toggleFormatting and addBlock helpers
geriux
added
[Status] In Progress
geriux
changed the title
2 tasks
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
…swiping to the right
derekblank
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
LGTM! I was able to successfully test the changes on iOS and Android. According to the mocks, I believe these toolbar buttons should be black, not blue, however. I wanted to check that that's what you intended #52336 for. Noting that, going ahead and approving. 🚀
# Conflicts: # packages/edit-post/src/components/header/header-toolbar/index.native.js
|
Flaky tests detected in 9ec99b1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5476236237
|
This was referenced Jul 26, 2023
dcalhoun
added a commit
that referenced
this pull request
Jan 23, 2024
All usage was removed in #52289. Additionally, the utility may be outdated and incompatible with the current editor UI.
dcalhoun
added a commit
that referenced
this pull request
Jan 24, 2024
All usage was removed in #52289. Additionally, the utility may be outdated and incompatible with the current editor UI.
dcalhoun
added a commit
that referenced
this pull request
Jan 25, 2024
* test: Increase `swipeDown` swipe distance The larger swipe distance results in faster scrolling, which will reduce the time it takes to scroll. The reduced time will mitigate the need to await longer scroll durations before asserting expectations and reduce test durations in general. Additionally, refactor both `swipeUp` and `swipeDown` to use an options parameter to communicate each argument intent, as well as improve alignment between the utilities. * test: Remove unused `removeBlockAtPosition` utility All usage was removed in #52289. Additionally, the utility may be outdated and incompatible with the current editor UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
What?
This PR moves the block mobile toolbar and moves the settings and more buttons to the header toolbar.
Why?
Part of the design changes project to make the mobile editor more consistent with the Web editor.
How?
isStackedHorizontallyprop. It also now renders the BlockSettingsButton, BlockMover, and BlockActionsMenu.swipeToolbarToElementto be able to scroll within the toolbar for cases of removing a block, adding a block, and toggling formatting buttons.Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-07-05.at.20.06.17.mp4