Sibling Inserter: Try reduced animation time and line indicator #22813
Conversation
…he inserter more discoverable. This is for testing a concept introduced in #22801
|
Size Change: +71 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
|
As stated in the comment above the
The cursor appearance should reflect what clicking it will do, so as long as this special click redirection behavior remains, I think the text cursor should stay. |
ZebulanStanphill
added
[Feature] Inserter
| @@ -339,7 +339,8 @@ | |||
| justify-content: center; | |||
|
|
|||
| // Clicks on the inserter are redirected to the nearest tabbable element. | |||
| cursor: text; | |||
| //cursor: text; | |||
| cursor: default; | |||
There was a problem hiding this comment.
If we aren't going to change the cursor we could just remove these lines.
|
Thank you for the PR! It's always the fastest way to improve things.
This seems, even on its own, like a fine improvement. The reason it was added in the first place is that the sibling inserter relies on the space between blocks, which varies from theme to theme, and may even be non-existent as we move closer to a wysiwyg experience (#22208 is not meant to be merged, but just for conversation). Specifically, this — or worse — might happen:
I'd love to find a better behavior for invoking the sibling inserter than hovering between two blocks, because of all it can conflict with.
Zebulan above provides the context. But the reason is that if you click in this space, you actually set focus in the nearest text:
The line showing up by default actually makes that less clear. We used to have a line that extended from the plus when the plus itself was hovered — do you think this would be sufficient? And if we do that, we should make it blue and the same style as the blue line that shows up on drag and drop and when inserting from the block library (#21475).
If we add the line, we can probably fix this with a |
|
I did some fiddling to find the ""magic time" and I find faster is a little better. What I did locally, was remove the delay built into the animation code (0-80%) and instead added it like this: And that timing felt pretty good. When moving a cursor fairly quickly, it tends not to show up. When moving slower, it still feels good to me. That all said, I think something like this could be an answer that provides a target before my cursor gets there removing guesswork. |
This feels like a sufficiently simple and basic approach, with a high yield, that it would be great to try on its own — it'll likely sail right through and improve things, and does not preclude further enhancements. Want to make a PR, Michael? You can assign me as reviewer if you like. |
|
+1 to @MichaelArestad's approach above to start, let's open a PR for that and work from there. I also like the suggestion in #22867 but starting with small timing improvements seems wise to get this moving. |
@jasmussen On it. |
|
Closing this one in favor of #23043 |
|
This issue may actually have been fixed in #23046 |
From: #22801
Description
This is a test for a concept introduced in #22801 (comment) to make the sibling inserter more discoverable.
I've spun this up quickly to show a proof of concept so folks can try it out and discuss.
Screenshots
How has this been tested?
Not tested.
Checklist: