Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sibling Inserter: Try reduced animation time and line indicator #22813

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/block-editor/src/components/block-list/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,8 @@
justify-content: center;

// Clicks on the inserter are redirected to the nearest tabbable element.
cursor: text;
//cursor: text;
cursor: default;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we aren't going to change the cursor we could just remove these lines.


// Hide the inserter above the selected block.
&.is-inserter-hidden .block-editor-inserter__toggle {
Expand Down Expand Up @@ -369,6 +370,7 @@
border-radius: $radius-block-ui;
color: $white;
padding: 0;
outline: 10px solid $white;

// Special dimensions for this button.
min-width: 24px;
Expand All @@ -385,7 +387,7 @@
.block-editor-block-list__block-popover-inserter {
.block-editor-inserter__toggle.components-button {
// Fade it in after a delay.
animation: block-editor-inserter__toggle__fade-in-animation-delayed 1.2s ease;
animation: block-editor-inserter__toggle__fade-in-animation-delayed 0.6s ease;
animation-fill-mode: forwards;
@include reduce-motion("animation");
}
Expand Down Expand Up @@ -558,6 +560,11 @@
box-shadow: none;
overflow-y: visible;
margin-left: 0;

border-top: 2px solid $light-gray-secondary;
animation: block-editor-inserter__toggle__fade-in-animation-delayed 0.6s ease;
animation-fill-mode: forwards;
@include reduce-motion("animation");
}
}

Expand Down