Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flaky Test] Keeps focus in place on undo in template parts #49386

Closed
github-actions bot opened this issue Mar 27, 2023 · 5 comments
Closed

[Flaky Test] Keeps focus in place on undo in template parts #49386

github-actions bot opened this issue Mar 27, 2023 · 5 comments
Labels
[Type] Flaky Test Auto-generated flaky test report issue

Comments

@github-actions
Copy link

github-actions bot commented Mar 27, 2023 •
edited
Loading

Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.

Test title

Keeps focus in place on undo in template parts

Test path

/test/e2e/specs/site-editor/template-part.spec.js

Errors

[2023-03-27T23:49:38.092Z] Test passed after 1 failed attempt on fix/unstable-disable-layout-classnames-in-group-block.
[2023-03-28T07:47:32.133Z] Test passed after 1 failed attempt on fix/selectors-api.
[2023-03-28T13:54:30.638Z] Test passed after 1 failed attempt on fix/home-link-class-space.
[2023-03-28T16:12:29.071Z] Test passed after 1 failed attempt on try/link-selected-block-with-global-styles-panel.
[2023-03-28T17:51:17.772Z] Test passed after 1 failed attempt on rnmobile/remove-keyboard-aware-flatlist.
[2023-03-28T20:13:12.097Z] Test passed after 1 failed attempt on test/add-writing-flow-tests.
[2023-03-29T07:08:13.517Z] Test passed after 1 failed attempt on trunk.
[2023-03-29T10:31:35.261Z] Test passed after 1 failed attempt on trunk.
[2023-03-29T12:07:15.919Z] Test passed after 1 failed attempt on fix/cover-fixed-featured-image-styles.
[2023-03-29T15:04:46.458Z] Test passed after 1 failed attempt on try/icon-updates.
[2023-03-29T16:00:21.014Z] Test passed after 2 failed attempts on trunk.
[2023-03-29T17:58:05.077Z] Test passed after 1 failed attempt on release/15.5.
[2023-03-29T17:58:23.323Z] Test passed after 1 failed attempt on wp/latest.
[2023-03-29T17:59:47.281Z] Test passed after 1 failed attempt on wp/latest.
[2023-03-29T21:27:01.242Z] Test passed after 1 failed attempt on fix/show-ui-to-change-custom-links-on-sidebar-navigation.
[2023-03-30T02:26:12.834Z] Test passed after 1 failed attempt on fix/selectors-api-use-in-duotone.
[2023-03-30T11:52:48.287Z] Test passed after 1 failed attempt on trunk.
[2023-03-30T12:11:25.333Z] Test passed after 1 failed attempt on trunk.
[2023-03-30T17:01:03.081Z] Test passed after 1 failed attempt on try/footnotes-again.
[2023-03-31T03:36:24.492Z] Test passed after 1 failed attempt on add/color-options-to-time-to-read-block.
[2023-03-31T04:21:06.498Z] Test passed after 1 failed attempt on try/minimal-margin.
[2023-03-31T08:01:12.679Z] Test passed after 1 failed attempt on add/root-client-id-to-list-view.
[2023-03-31T15:06:25.891Z] Test passed after 1 failed attempt on try/use-dedicated-rest-to-get-nav-fallbacks.
[2023-04-01T02:35:17.454Z] Test passed after 1 failed attempt on tweak/simplify-remove-block-label.
[2023-04-03T05:04:58.920Z] Test passed after 1 failed attempt on try/minimal-margin.
[2023-04-03T05:35:42.600Z] Test passed after 1 failed attempt on trunk.
[2023-04-03T08:24:08.259Z] Test passed after 1 failed attempt on fix/start-template-options-missing-focus-style.
[2023-04-03T09:03:07.117Z] Test passed after 1 failed attempt on try/resize-visualizer.
[2023-04-03T09:06:41.783Z] Test passed after 1 failed attempt on try/link-selected-block-with-global-styles-panel.
[2023-04-03T09:06:52.458Z] Test passed after 1 failed attempt on fix/start-template-options-missing-focus-style.
[2023-04-03T17:39:18.899Z] Test passed after 1 failed attempt on tweak/simplify-remove-block-label.
[2023-04-04T00:21:58.806Z] Test passed after 1 failed attempt on update/list-view-aria-attributes.
[2023-04-04T01:40:46.387Z] Test passed after 1 failed attempt on add/show-hide-breadcrumbs-site-editor.
[2023-04-04T06:19:40.699Z] Test passed after 1 failed attempt on update/list-view-aria-attributes.
[2023-04-04T08:19:08.612Z] Test passed after 1 failed attempt on trunk.
[2023-04-04T10:17:21.525Z] Test passed after 1 failed attempt on refactor/shadow-panel.
[2023-04-04T13:41:29.225Z] Test passed after 1 failed attempt on add/commands.
[2023-04-04T14:58:41.692Z] Test passed after 1 failed attempt on try/cmd-click-navigation.
[2023-04-04T18:40:33.423Z] Test passed after 1 failed attempt on chore/components-changelog.
[2023-04-04T21:32:47.547Z] Test passed after 1 failed attempt on add/spacing-presets-to-spacer-block.
[2023-04-04T23:24:17.191Z] Test passed after 1 failed attempt on rnmobile/add-reassure-ci.
[2023-04-05T14:02:08.083Z] Test passed after 1 failed attempt on changlelog-check-test-branch.
[2023-04-05T16:18:19.429Z] Test passed after 1 failed attempt on trunk.
[2023-04-05T17:00:31.944Z] Test passed after 1 failed attempt on components-changelog-check.
[2023-04-06T03:08:07.785Z] Test passed after 1 failed attempt on trunk.
[2023-04-06T07:31:28.353Z] Test passed after 1 failed attempt on add/tests-for-list-view-drop-zone-logic.
[2023-04-06T08:14:37.685Z] Test passed after 1 failed attempt on try/link-selected-block-with-global-styles-panel.
[2023-04-06T14:24:05.753Z] Test passed after 1 failed attempt on update-boding-guidelines-experimental.
[2023-04-06T15:08:58.962Z] Test passed after 1 failed attempt on refactor/edit-site-lodash-map-values.
[2023-04-07T15:29:22.681Z] Test passed after 2 failed attempts on fix/avoid-empty-gallery-block-error.
[2023-04-10T11:43:25.858Z] Test passed after 1 failed attempt on rnmobile/remove-keyboard-aware-flatlist.
[2023-04-10T17:27:28.206Z] Test passed after 1 failed attempt on component-changelog-check-exclude-mobile.
[2023-04-10T18:04:50.467Z] Test passed after 1 failed attempt on component-changelog-check-exclude-mobile.
[2023-04-10T19:39:39.632Z] Test passed after 1 failed attempt on rnmobile/release_1.92.1.
[2023-04-10T19:55:45.744Z] Test passed after 1 failed attempt on rnmobile/release_1.92.1.
[2023-04-11T06:10:21.603Z] Test passed after 1 failed attempt on try/user-global-styles-revisions.
[2023-04-11T07:58:23.169Z] Test passed after 1 failed attempt on trunk.
[2023-04-12T10:13:41.791Z] Test passed after 1 failed attempt on fix/block-toolbar-height.
[2023-04-12T12:00:47.907Z] Test passed after 1 failed attempt on try/block-tools-invade-document-tools.
[2023-04-12T12:41:08.044Z] Test passed after 1 failed attempt on update/gen-block-lib-list.
[2023-04-12T14:12:16.300Z] Test passed after 1 failed attempt on trunk.
[2023-04-12T16:01:52.148Z] Test passed after 1 failed attempt on try/block-tools-invade-document-tools.
[2023-04-12T16:05:27.519Z] Test passed after 1 failed attempt on rnmobile/add-viewport-settings.
[2023-04-12T17:04:06.894Z] Test passed after 1 failed attempt on fix/social-link-select-radius.
[2023-04-12T17:11:20.129Z] Test passed after 1 failed attempt on fix/flaky-site-editor-writing-flow-tests.
[2023-04-12T17:56:53.037Z] Test passed after 1 failed attempt on wp/latest.
[2023-04-13T03:42:41.350Z] Test passed after 1 failed attempt on trunk.
[2023-04-13T04:03:07.813Z] Test passed after 1 failed attempt on trunk.
[2023-04-13T04:50:03.285Z] Test passed after 1 failed attempt on try/spacer-flex-controls.
[2023-04-14T03:59:49.628Z] Test passed after 1 failed attempt on update/fluid-typography-use-layout-as-viewport-values.
[2023-04-19T17:00:44.275Z] Test passed after 1 failed attempt on release/15.6.
[2023-04-21T17:46:14.591Z] Test passed after 1 failed attempt on release/15.6. 
Error: frame.click: Frame was detached
=========================== logs ===========================
waiting for locator('body')
  locator resolved to <body tabindex="0" contenteditable="false" class="bloc…>…</body>
============================================================
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/template-part.spec.js:370:23
@github-actions github-actions bot added the [Type] Flaky Test Auto-generated flaky test report issue label Mar 27, 2023
This was referenced Mar 27, 2023
Merged
Merged
Merged
Merged
Merged
Merged
@Mamaduka
Copy link
Member

@draganescu, the new test seems to be flaky.

github-actions bot referenced this issue Mar 29, 2023
@richtabor
ImageSizeControl: Remove the "Image Dimensions" label (#49414)
d3f7f57 
* Remove the Image Dimensions label

* Update CHANGELOG.md
github-actions bot referenced this issue Mar 29, 2023
@jsnajdr
useSelect: incrementally subscribe to stores when first selected from (…
51d6144 
…#47243)

* useSelect tests: unify counter store definitions

* useSelect: incrementally subscribe to stores when first selected from

* useSelect: keep lastMapResult and lastMapSelect always in sync

* useSelect: improve unit test that tests store updates between render and subscription

* useSelect: add test for store updates after selector change
This was referenced Mar 29, 2023
Merged
Merged
github-actions bot referenced this issue Mar 29, 2023
@gutenbergplugin
Bump plugin version to 15.5.0-rc.1
8ad5908
github-actions bot referenced this issue Mar 29, 2023
@gutenbergplugin
chore(release): publish
a16b0d1 
 - @wordpress/a11y@3.30.0
 - @wordpress/annotations@2.30.0
 - @wordpress/api-fetch@6.27.0
 - @wordpress/autop@3.30.0
 - @wordpress/babel-plugin-import-jsx-pragma@4.13.0
 - @wordpress/babel-plugin-makepot@5.14.0
 - @wordpress/babel-preset-default@7.14.0
 - @wordpress/base-styles@4.21.0
 - @wordpress/blob@3.30.0
 - @wordpress/block-directory@4.7.0
 - @wordpress/block-editor@11.7.0
 - @wordpress/block-library@8.7.0
 - @wordpress/block-serialization-default-parser@4.30.0
 - @wordpress/block-serialization-spec-parser@4.30.0
 - @wordpress/blocks@12.7.0
 - @wordpress/browserslist-config@5.13.0
 - @wordpress/components@23.7.0
 - @wordpress/compose@6.7.0
 - @wordpress/core-data@6.7.0
 - @wordpress/create-block-tutorial-template@2.18.0
 - @wordpress/create-block@4.14.0
 - @wordpress/customize-widgets@4.7.0
 - @wordpress/data-controls@2.30.0
 - @wordpress/data@9.0.0
 - @wordpress/date@4.30.0
 - @wordpress/dependency-extraction-webpack-plugin@4.13.0
 - @wordpress/deprecated@3.30.0
 - @wordpress/docgen@1.39.0
 - @wordpress/dom-ready@3.30.0
 - @wordpress/dom@3.30.0
 - @wordpress/e2e-test-utils@10.1.0
 - @wordpress/e2e-tests@7.1.0
 - @wordpress/edit-post@7.7.0
 - @wordpress/edit-site@5.7.0
 - @wordpress/edit-widgets@5.7.0
 - @wordpress/editor@13.7.0
 - @wordpress/element@5.7.0
 - @wordpress/env@5.15.0
 - @wordpress/escape-html@2.30.0
 - @wordpress/eslint-plugin@14.3.0
 - @wordpress/format-library@4.7.0
 - @wordpress/hooks@3.30.0
 - @wordpress/html-entities@3.30.0
 - @wordpress/i18n@4.30.0
 - @wordpress/icons@9.21.0
 - @wordpress/interface@5.7.0
 - @wordpress/is-shallow-equal@4.30.0
 - @wordpress/jest-console@7.1.0
 - @wordpress/jest-preset-default@11.1.0
 - @wordpress/jest-puppeteer-axe@6.1.0
 - @wordpress/keyboard-shortcuts@4.7.0
 - @wordpress/keycodes@3.30.0
 - @wordpress/lazy-import@1.17.0
 - @wordpress/list-reusable-blocks@4.7.0
 - @wordpress/media-utils@4.21.0
 - @wordpress/notices@3.30.0
 - @wordpress/npm-package-json-lint-config@4.15.0
 - @wordpress/plugins@5.7.0
 - @wordpress/postcss-plugins-preset@4.14.0
 - @wordpress/postcss-themes@5.13.0
 - @wordpress/preferences-persistence@1.22.0
 - @wordpress/preferences@3.7.0
 - @wordpress/prettier-config@2.13.0
 - @wordpress/primitives@3.28.0
 - @wordpress/priority-queue@2.30.0
 - @wordpress/private-apis@0.12.0
 - @wordpress/project-management-automation@1.29.0
 - @wordpress/react-i18n@3.28.0
 - @wordpress/readable-js-assets-webpack-plugin@2.13.0
 - @wordpress/redux-routine@4.30.0
 - @wordpress/reusable-blocks@4.7.0
 - @wordpress/rich-text@6.7.0
 - @wordpress/scripts@26.1.0
 - @wordpress/server-side-render@4.7.0
 - @wordpress/shortcode@3.30.0
 - @wordpress/style-engine@1.13.0
 - @wordpress/stylelint-config@21.13.0
 - @wordpress/token-list@2.30.0
 - @wordpress/url@3.31.0
 - @wordpress/viewport@5.7.0
 - @wordpress/warning@2.30.0
 - @wordpress/widgets@3.7.0
 - @wordpress/wordcount@3.30.0
github-actions bot referenced this issue Mar 29, 2023
@gutenbergplugin
Merge changes published in the Gutenberg plugin "release/15.5" branch
b88fa5f
github-actions bot referenced this issue Mar 29, 2023
@gutenbergplugin
Update changelog files
c62971f
This was referenced Mar 29, 2023
Merged
Merged
@draganescu
Copy link
Contributor

Seems so. I'll see what this is about

@draganescu
Copy link
Contributor

It seems to be the detached problem which is unrelated to the test:

Error: frame.click: Frame was detached
    =========================== logs ===========================
    waiting for locator('body')
      locator resolved to <body></body>
    attempting click action
      waiting for element to be visible, enabled and stable
        element is not visible - waiting...
    element was detached from the DOM, retrying
    ============================================================

      368 | 			postType: 'wp_template_part',
      369 | 		} );
    > 370 | 		await editor.canvas.click( 'body' );

running:

npm run test:e2e:playwright -- --repeat-each 20 -g "Keeps focus in place on undo in template parts"

@draganescu
Copy link
Contributor

See #49374

github-actions bot referenced this issue Mar 30, 2023
@mirka @ciampo
Components: Ship TypeScript types (#49229)
8528e49 
* Components: Ship TypeScript types

* Rename entry points

---------

Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com>
github-actions bot referenced this issue Mar 30, 2023
@getdave
Add automatted tests for Nav block editable list view (#49433)
d9dd82a 
* Scaffold initial test

* Assert on menu structure

* Refine structure test filters

* Assert using appender to add menu items

* Improve assertions to check the type of the link being inserted

* Improve asserting on Page and Custom links being 1st and 2nd results

* Test block removal

* Make test describe blocks consistent with other tests

* Add test for editing items

* Test for adding submenus

* Remove uneccessary test wording

* Remove unecessary click on List View tab

Should be visible by default. Left one test which will fail if the tab isn’t automatically pre-selected.

* Extract blocks to a var

* Add Link Control test helper and extract relevant portions of tests

* Extract util for getting result text

* Remove unneeded focus of item to trigger options menu

* Avoid overly complex selectors by targetted Submenu for item removal test

* Remove comment

* Test editing a menu item actually updates in the list view

* Remove .only
This was referenced Mar 30, 2023
Closed
Merged
Merged
Merged
Merged
Merged
github-actions bot referenced this issue Apr 3, 2023
@talldan
Fix site editor isFeatureActive deprecation (#49545)
6c41347 
- Use correct store name
- Add @deprecated to jsdoc block
This was referenced Apr 4, 2023
Merged
Merged
Open
Closed
github-actions bot referenced this issue Apr 5, 2023
@gutenbergplugin
Update Changelog for 15.5.0
cf42f1c
@github-actions github-actions bot mentioned this issue Apr 5, 2023
Merged
github-actions bot referenced this issue Apr 6, 2023
@carolinan
Add Details/summary block (#45055)
b23e214 
* Add  "details" block

* Add variation, fix stylesheet loading on front, change font size

* Remove the link option from the summary heading, update aria label

* Update edit.js

* Keep the details open in the editor

* Add toolbar control for collapsing and expanding the details, remove border

* Update fixtures

* Update style.scss

* re-add the font size for the heading

* Remove font size limitations

* Update cursor to pointer.

* Add aria label that announces the expanded or collapsed state

* Remove transcript variation, add keywords

* Open the details when the block is selected

* Update edit.js

* Add a basic unwrap

* Update edit.js

* Try using separate blocks

* Update summary text, descriptions and fixtures

* Update edit.js

* remove transform and editor style.

* update icons.

* Limit the inner blocks to one inside the Details block

* Remove the alignments from the inner blocks, and prevent them from being used as reusable blocks.

* Update index.js

* Add the icon

* Try to apply font size to the heading inside summary

* Update fixtures

* Remove the allowed formatting from the RichText

* Try the experimentalSelector and skipSerialization again

* Remove heading from Summary

* Rename the block, update CSS.

* Update style.scss

* Change the category to text

* Remove unsupported marker CSS

* fix background clipping and update description

* Replace inner div with View primitive

* Remove View from save.js

* Remove translation from save.js

* Make the block opt-in, available from the Experiments page.

* remove fixtures
This was referenced Apr 6, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Closed
github-actions bot referenced this issue Apr 11, 2023
@aristath
Typo: The stylesheet handle is defined as wp-reusable-blocks above (#…
833176a 
…49632)
This was referenced Apr 12, 2023
Merged
Merged
Merged
github-actions bot referenced this issue Apr 12, 2023
@fluiddot
[RNMobile] Add core-js relative indexing method polyfills (#49749)
71f1f6d
This was referenced Apr 12, 2023
Merged
Closed
Closed
github-actions bot referenced this issue Apr 13, 2023
@carolinan @aristath
Update theme.json reference docs to include more sections (#48250)
724f577 
* Update theme.json reference docs to include more sections
---------

Co-authored-by: Ari Stathopoulos <aristath@gmail.com>
github-actions bot referenced this issue Apr 13, 2023
@ramonjd
Removing innerprops from wrapper so that it doesn't create a new grou…
6d9a82b 
…p block (#49783)
This was referenced Apr 13, 2023
Merged
Merged
github-actions bot referenced this issue Apr 19, 2023
@gutenbergplugin
Update Changelog for 15.6.0
70af40b
github-actions bot referenced this issue Apr 21, 2023
@gutenbergplugin
Update Changelog for 15.6.2
12e16b8
@draganescu
Copy link
Contributor

I'll close this since the "detached" whatever seems fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@draganescu @Mamaduka