Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: exclude mobile-only PRs from CHANGELOG update CI check #49688

Merged
merged 3 commits into from
Apr 11, 2023

Conversation

chad1008
Copy link
Contributor

@chad1008 chad1008 commented Apr 10, 2023

What?

Excludes PRs changing only mobile/native files from the CI check for CHANGELOG updates

Why?

First noticed here, this check doesn't fit with the mobile team's current workflow, causing their PRs to fail unexpectedly.

How?

Sets the workflow to not run if all of the changed files are native/mobile, using the existing paths from the package's ts-config exclusion as a guide. I've also added an exclusion for *.native.scss files, which wouldn't be covered.

Note

As mentioned above, I've used ts-config's exclusions as a starting point, but I don't think there are actually any react-native-* directories in the package at the moment. I'm not sure if that makes it a good exclusion to include, or if it's obsolete and can be skipped.

Testing Instructions

  1. Check out this PR, and create a new branch of off it
  2. Update component files matching the modified paths:
  • at least one *.native.js, *.native.scss, *.ios.js, and *.android.js file
  • at least one file file in a react-native-* folder (you'll need to create one, as I don't think there are currently any in the package)
  1. Push your changes and open a test PR. Confirm that the changelog verification check is not run.
  2. Modify a non-mobile component file
  3. Push you changes and confirm that the check does run as expected

@github-actions
Copy link

github-actions bot commented Apr 10, 2023

Flaky tests detected in d9f0624.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4659385399
📝 Reported issues:

@chad1008 chad1008 changed the title fix typo in test exclusion path Components: exclude mobile-only PRs from CHANGELOG update CI check Apr 10, 2023
@chad1008 chad1008 marked this pull request as ready for review April 10, 2023 18:26
@chad1008 chad1008 requested review from geriux, mirka and ciampo April 10, 2023 18:28
@chad1008 chad1008 self-assigned this Apr 10, 2023
@chad1008 chad1008 added [Package] Components /packages/components GitHub Actions Pull requests that update GitHub Actions code labels Apr 10, 2023
Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@chad1008 chad1008 merged commit 3317ba1 into trunk Apr 11, 2023
@chad1008 chad1008 deleted the component-changelog-check-exclude-mobile branch April 11, 2023 20:29
@github-actions github-actions bot added this to the Gutenberg 15.6 milestone Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitHub Actions Pull requests that update GitHub Actions code [Package] Components /packages/components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants