Fix: Show UI to update custom links on the sidebar navigation. #48939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
|
Size Change: +296 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
fix/show-ui-to-change-custom-links-on-sidebar-navigation
branch
2 times, most recently
from
e39ce7a to
5de37ca
Compare
|
Flaky tests detected in 5619e75. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4562710990
|
Mamaduka
added
[Feature] Site Editor
jorgefilipecosta
force-pushed
the
fix/show-ui-to-change-custom-links-on-sidebar-navigation
branch
4 times, most recently
from
d4b1701 to
66aed93
Compare
apeatling
reviewed
Mar 29, 2023
jorgefilipecosta
force-pushed
the
fix/show-ui-to-change-custom-links-on-sidebar-navigation
branch
from
66aed93 to
5619e75
Compare
|
Thank you for your tests @apeatling. Given that is not a big change and it is certainly better than what we have now where nothing happens, I will merge this PR. If anyone has any further feedback, we can iterate also, in case of an unexpected issue, it is ok to revert this PR. |
jorgefilipecosta
deleted the
fix/show-ui-to-change-custom-links-on-sidebar-navigation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #48593
This PR fixes a bug where it is not possible to change custom links on the sidebar navigation:
Testing Instructions
Add a custom link and verify it is possible to change its URL and label on the sidebar navigation.
Screenshot