Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom link handling in Navigation panel #48593

Closed
jameskoster opened this issue Feb 28, 2023 · 3 comments · Fixed by #48939
Closed

Custom link handling in Navigation panel #48593

jameskoster opened this issue Feb 28, 2023 · 3 comments · Fixed by #48939
Assignees
@jorgefilipecosta
Labels
[Block] Navigation Affects the Navigation Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@jameskoster
Copy link
Contributor

Working with Custom Links in the Site Editor's Navigation panel is extremely clunky:

custom.link.mp4
  • There's no way to edit the link details.
  • It's possible to select the item, but nothing happens. The subsequent appearance looks broken (grey on blue).
@jameskoster jameskoster added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Needs design efforts. labels Feb 28, 2023
@annezazu
Copy link
Contributor

annezazu commented Mar 1, 2023

Is this worth adding to the 6.2 board? I know work is being done to update the inserter to prioritize page links but this still feels quite broken.

@ndiego ndiego moved this to ❓ Triage in WordPress 6.2 Editor Tasks Mar 2, 2023
@jameskoster jameskoster mentioned this issue Mar 2, 2023
Closed
10 tasks
@jameskoster jameskoster added the [Block] Navigation Affects the Navigation Block label Mar 2, 2023
@SaxonF
Copy link
Contributor

SaxonF commented Mar 3, 2023

The changes in #48612 will cover custom link editing, but we'll still need to add the ability to trigger the edit dialog from browse mode navigation sidebar. Once the other issue is complete, we can use this issue to track the triggering.

custom-link.mp4

@jameskoster
Copy link
Contributor Author

That seems to work reasonably well.

@jameskoster jameskoster removed the Needs Design Needs design efforts. label Mar 3, 2023
@jameskoster jameskoster mentioned this issue Mar 3, 2023
Closed
@jorgefilipecosta jorgefilipecosta self-assigned this Mar 3, 2023
@ndiego ndiego moved this from ❓ Triage to 🗣️ In discussion, needs decision in WordPress 6.2 Editor Tasks Mar 8, 2023
@richtabor richtabor mentioned this issue Mar 8, 2023
Merged
@jorgefilipecosta jorgefilipecosta mentioned this issue Mar 8, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 8, 2023
@ndiego ndiego moved this from 🗣️ In discussion, needs decision to 🐛 Punted to 6.2.1 in WordPress 6.2 Editor Tasks Mar 9, 2023
@jasmussen jasmussen moved this to Todo 6.2 in 6.3 Design Mar 16, 2023
@jasmussen jasmussen moved this from Todo 6.2 to Todo in 6.3 Design Mar 16, 2023
@annezazu annezazu moved this to 💻 Needs development in Gutenberg Phase 2: Customization Mar 20, 2023
@jameskoster jameskoster moved this from Needs design to Blocked in 6.3 Design Mar 22, 2023
@github-project-automation github-project-automation bot moved this from 💻 Needs development to ✅ Done in Gutenberg Phase 2: Customization Mar 30, 2023
@github-project-automation github-project-automation bot moved this from Blocked to Needs dev in 6.3 Design Mar 30, 2023
@github-project-automation github-project-automation bot moved this from 🐛 Punted to 6.2.1 to ✅ Done in WordPress 6.2 Editor Tasks Mar 30, 2023
@jameskoster jameskoster moved this from Needs dev to Done in 6.3 Design Apr 13, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorgefilipecosta jorgefilipecosta

Labels
[Block] Navigation Affects the Navigation Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
6.3 Design
Status: Done
Gutenberg Phase 2: Customization
Status: ✅ Done
WordPress 6.2 Editor Tasks
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Show UI to update custom links on the sidebar navigation. WordPress/gutenberg
5 participants
@jameskoster @SaxonF @jorgefilipecosta @annezazu @priethor