Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor Navigation panel: Site Logo, Search, Spacer, Social Icon, Page List experience feels a bit broken. #48675

Closed
jameskoster opened this issue Mar 2, 2023 · 11 comments
Labels
[Block] Navigation Affects the Navigation Block Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Type] Bug An existing feature does not function as intended

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Mar 2, 2023

If there's a Site Logo block in the main navigation, you're not able to edit it in the Navigation panel:

logo.mp4

But you are able to select it, which does nothing. This experience feels quite broken.

For 6.2 let's explore more appropriate interaction design, IE remove the select-ability of these items. In the future it'd be nice if there was simple edit UIs for these blocks within this panel.

@jameskoster jameskoster added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block Needs Design Needs design efforts. labels Mar 2, 2023
@jameskoster jameskoster changed the title Site Editor Navigation panel: Not possible to edit site logo Site Editor Navigation panel: Site Logo, Search, Spacer, Social Icon experience feels a bit broken. Mar 2, 2023
@jameskoster
Copy link
Contributor Author

I think removing all hover interactions (except the grab cursor and exposing the ellipsis button), and making these blocks un-selectable would help a lot as a short term measure:

logo.mp4

@jameskoster jameskoster added the Needs Design Feedback Needs general design feedback. label Mar 2, 2023
@jameskoster jameskoster changed the title Site Editor Navigation panel: Site Logo, Search, Spacer, Social Icon experience feels a bit broken. Site Editor Navigation panel: Site Logo, Search, Spacer, Social Icon, Page List experience feels a bit broken. Mar 2, 2023
@jameskoster
Copy link
Contributor Author

Related: Selecting the Page List when the children are revealed adds a background color that looks broken:

Screenshot 2023-03-02 at 12 44 39

@jameskoster
Copy link
Contributor Author

Noting that if we can't get custom link editing (#48593) in time for 6.2, then it would probably be ok for them to behave like the other blocks here. Hopefully it doesn't come to that, though :)

@richtabor
Copy link
Member

We should almost remove the non-browsable blocks from this Site Editor > Navigation view...

@jameskoster
Copy link
Contributor Author

Do you mean remove the affordances by which you can add those blocks to Navigation menus?

Or just hide them in this view?

The problem with the latter is that you wouldn't be able to re-order, which seems like a shame?

@richtabor
Copy link
Member

Or just hide them in this view?

We're mixing browse mode w/ block editing.

The problem with the latter is that you wouldn't be able to re-order, which seems like a shame?

Are any block themes using blocks in navigation out of the box? All the core header patterns don't have logo/social/search in the actual navigation block (but rather within a row, next to the Navigation block).

I'm curious how meaningful it is to have access to those other blocks in the navigation period — why I lean towards hiding them in the Site Editor > Navigation view.

@SaxonF
Copy link
Contributor

SaxonF commented Mar 7, 2023

This is a tough one...

We're mixing browse mode w/ block editing.

I agree and in general have concerns about how we communicate what the navigation section's main purpose is compared to the navigation block itself. If we were to hide blocks I would much prefer we present the section as "Pages", but still allow re-ordering of pages (setting order attribute), which in turn would affect all menus that include a pages list block. This would cover most simple sites and leave advanced menu editing to the editor.

In saying that though, we're kind of at a point where we need to run with positioning this as menu management, and if we hide blocks in the list we'd also need to hide them from the inserter, which then creates inconsistencies with the editor etc. I think @jameskoster proposal here is a good improvement in the short term.

@jameskoster
Copy link
Contributor Author

Imo this speaks to an underlying issue around whether the Navigation block should be able to entertain children like Search, Social Icons, etc.

Still, as long as they can, I'm struggling to come up with a compelling reason why you shouldn't be able to at least re-order them in this view.

Like Saxon said, if we hide them in the list then we also need to hide them in the Inserter, and so the list of overrides made to the off-canvas menu editor gets ever longer, to the point where it's almost entirely divergent.

@jorgefilipecosta
Copy link
Member

Could we just disable the selection from these blocks, so they are essentially disabled?

@jameskoster
Copy link
Contributor Author

@jorgefilipecosta if that wouldn't prohibit re-ordering them then yes, that would be ideal.

@ndiego ndiego moved this from 🗣️ In discussion, needs decision to 🐛 Punted to 6.2.1 in WordPress 6.2 Editor Tasks Mar 9, 2023
@jameskoster
Copy link
Contributor Author

There's refinement still to do, but I think #48933 is enough to close this.

@github-project-automation github-project-automation bot moved this from 🐛 Punted to 6.2.1 to ✅ Done in WordPress 6.2 Editor Tasks Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

No branches or pull requests

4 participants