Occur "Maximum update depth exceeded.” in Navigation Screen.

[torounit]

Description

Adding a Custom Link block to the navigation causes "Maximum update depth exceeded.”

This problem does not occur in 15.2.4, it occurs with trunk ( 4945d3f ).

Uncaught Error: Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limits the number of nested updates to prevent infinite loops.
    at checkForNestedUpdates (react-dom.js?ver=18:27302:13)
    at scheduleUpdateOnFiber (react-dom.js?ver=18:25485:5)
    at dispatchSetState (react-dom.js?ver=18:17537:9)
    at assignRef (index.js:20:3)
    at index.js:128:4
    at safelyDetachRef (react-dom.js?ver=18:22918:24)
    at commitDeletionEffectsOnFiber (react-dom.js?ver=18:24013:13)
    at recursivelyTraverseDeletionEffects (react-dom.js?ver=18:23999:7)
    at commitDeletionEffectsOnFiber (react-dom.js?ver=18:24128:11)
    at recursivelyTraverseDeletionEffects (react-dom.js?ver=18:23999:7)

Step-by-step reproduction instructions

1. Go to Site Editor.
2. Select Navigation Screen. ( http://localhost:8888/wp-admin/site-editor.php?canvas=view&path=%2Fnavigation )
3. Insert "Custom Link" Block to Navigation.

Screenshots, screen recording, code snippet

2023-03-02.16.48.57.mov

Environment info

• Gutenberg: trunk ( 4945d3f )

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[Mamaduka]

I can confirm the bug. This only happens when inserting the "Custom Link" block.

[Mamaduka]

Probably related to #48675.

cc @getdave, @scruffian

[Mamaduka]

I believe this is the side effect that triggers the update loop.

gutenberg/packages/block-library/src/navigation-link/edit.js

Lines 228 to 235 in a85892e

	useEffect( () => {
	// This side-effect should not create an undo level as those should
	// only be created via user interactions. Mark this change as
	// not persistent to avoid undo level creation.
	// See https://github.com/WordPress/gutenberg/issues/34564.
	__unstableMarkNextChangeAsNotPersistent();
	setAttributes( { isTopLevelLink } );
	}, [ isTopLevelLink ] );

[getdave]

That bug is already on the radar and will be fixed by

#48219

Thanks for reporting.

[ntsekouras]

This PR seems to have caused this: #47853 and it's not included in 6.2.

[Mamaduka]

@getdave, should we close some of the issues as duplicates?

[getdave]

@Mamaduka I've marked this Issue as being closed by #48219. So it will be handled.