Tweak remove block label to make it simpler #49529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +4.22 kB (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 1e2e50f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4630051363
|
alexstine
reviewed
Apr 1, 2023
packages/block-editor/src/components/block-settings-menu/block-settings-dropdown.js
Show resolved
Hide resolved
|
Removing the block name makes sense to me. The name is already present in the toolbar, and this menu item becomes unwieldy when dealing with blocks that have a long name (mostly template parts and reusable blocks). Speaking of... do you think there's a risk that 'delete' could be misconstrued when dealing with those blocks? |
alexstine
approved these changes
Apr 3, 2023
I don't think so. The term "Delete" seems more common/standard practice. What do you think may be misunderstood? |
We'll be offering two delete actions for template parts / reusable blocks. One in the management views which permanently deletes from the entire site. And one in the full-screen editor which just removes it from the current document. Hopefully the context will adequately clarify the differences though. |
jameskoster
approved these changes
Apr 4, 2023
|
🚀 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Simplifies the "Remove {blockName}" menu item within the block settings menu, in support of #49271 (comment)).
Renders "Delete" when one block is selected, and "Delete blocks" when more than one block is selected.
Why?
We don't have, nor need, additional context on any other menu item (nor this one), as it can be quite noisy and harder to scan.
How?
Testing Instructions
Screenshots or screencast
Before:
After: