Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to windows 0.51 #3

Merged
merged 2 commits into from
Aug 26, 2023
Merged

Upgrade to windows 0.51 #3

merged 2 commits into from
Aug 26, 2023

Conversation

MarijnS95
Copy link
Member

@MarijnS95 MarijnS95 commented Aug 16, 2023

Some neat cleanup and improvements in this release, including massively simplified bindgen API.

This is still "draft" as the necessary "bingen" utilities were set to be published (microsoft/windows-rs#2607, microsoft/windows-rs#2609), but have not yet made it to crates.io (though they are not needed to consume this crate!).

Still on the fence whether to go the cargo install riddle; riddle --etc bindings.txt route, or whether to keep the cargo r -p api_gen crate now that windows-rs decided to keep a windows-bindgen library crate that we can instead give these arguments to 1.

Footnotes

  1. Meaning that the riddle utility does not need to be separately installed, because running the api_gen crate through cargo automatically downloads and compiles dependencies.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@MarijnS95 MarijnS95 force-pushed the windows-0.51 branch 2 times, most recently from c873688 to 8263f5e Compare August 16, 2023 09:37
@MarijnS95
Copy link
Member Author

Decided to stick with windows-bindgen to save on a manual cargo install riddle, and because it's not published yet, requiring an install from git (and cloning the windows-rs repo takes ages).

@MarijnS95 MarijnS95 enabled auto-merge (squash) August 17, 2023 14:42
auto-merge was automatically disabled August 26, 2023 11:42

Merge queue setting changed

@Jasper-Bekkers Jasper-Bekkers removed the request for review from manon-traverse August 26, 2023 11:42
@Jasper-Bekkers Jasper-Bekkers added this pull request to the merge queue Aug 26, 2023
Merged via the queue into main with commit fa55fdb Aug 26, 2023
@Jasper-Bekkers Jasper-Bekkers deleted the windows-0.51 branch August 26, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants