Make riddle available as a library

[kennykerr]

This update makes the riddle tool available as a library crate.

• I've repurposed the windows-bindgen crate rather than minting yet another crate.
• The "default" metadata is now included by the windows-bindgen crate directly. This can be turned off using default-features = false as the riddle tool does.
• The tool_core crate used internally by windows-rs illustrates how to use windows-bindgen as a library (9b17c65).
• The interface is the same between riddle and windows-bindgen namely string arguments. The choice is thus purely whether you need a library or prefer a command line tool.

@ChrisDenton does this improve your developer experience?

The rest of the PR has a lot of noise but that's largely just generated comments getting updated/removed.

Fixes: #2593
Fixes: #2607

[kennykerr]

Ideally you can just pass library/std/src/sys/windows/c/windows_sys.lst directly to windows-bindgen. 😊

[ChrisDenton]

I had a brief look and, yep, this looks easier to integrate. I'll do a draft PR to rust-lang tomorrow and see if anything shakes out (iirc there have also been quite a few changes since the last metadata update).

Ideally you can just pass library/std/src/sys/windows/c/windows_sys.lst directly to windows-bindgen. 😊

Slightly tricky atm because we have comments in the windows_sys.lst file. And we add a few bits to the output file too (mostly just to make arm32 not be a compile error),

[kennykerr]

Sounds good. Let me know if you need me to tweak anything. I can also skip comments if that's the only obstacle.

[ChrisDenton]

Yeah, I think the comments are the only issue with input.

I did notice that FindFirstFileW is returning a HANDLE type instead of a FindFileHandle. Was that intentional?

Also minor thing but I think it'd be good to remove the std special case for SOCKET. It should now be easy to use the windows-sys type internally.

[kennykerr]

The FindFirstFileW thing probably flipped around in the Win32 metadata. I can't point to a commit or PR as they don't have a good way of tracking changes. I'm planning on stabilizing that as soon as I have a few more pieces in place for riddle. Sorry about that. For what it's worth, I think HANDLE is correct.

I'll have a PR up tomorrow with the changes for stripping comments and removing the specializations. You can then double check that for me. Be great to have less differences.

[ChrisDenton]

The FindFirstFileW thing probably flipped around in the Win32 metadata. I can't point to a commit or PR as they don't have a good way of tracking changes. I'm planning on stabilizing that as soon as I have a few more pieces in place for riddle. Sorry about that. For what it's worth, I think HANDLE is correct.

Tbh it ultimately doesn't matter for sys style bindings, other than making the diff nicer, I was more curious.

Be great to have less differences.

Yep! I hope to continue pecking away at the differences.