Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nav component #12

Merged
merged 8 commits into from
Apr 25, 2022
Merged

feat: nav component #12

merged 8 commits into from
Apr 25, 2022

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Apr 25, 2022

Overview / Changes

Add nav component.

Related

Testing / Screenshots

  1. Review Core Nav Pattern (dev).
  2. Change screen size from wide to narrow and back.
  3. On wide screen:
    • links should have less space between them.
    • link vertical clickable area should extend a tad beyond its text
    • link horizontal clickable area should extend a tad beyond its text
  4. On narrow screen:
    • links should have more space between them
    • link vertical clickable area should extend well beyond its text
    • link horizontal clickable area should extend a tad beyond its text
  5. Previous features must not have changed:
    • boxed unordered list item have bullets prefixes
    • ordered list items have numerical prefixes
    • no list links line up on a row and wrap
* If you want to test locally, then create these snippets (click to reveal):

HTML: "(basic)"
TEMPLATE: snippets/manual-pattern-library/c-nav.html

HTML: c-nav--boxed
TEMPLATE: snippets/manual-pattern-library/c-nav.html

@wesleyboar wesleyboar force-pushed the task/ECEP-114-nav-component branch from c0e0482 to ccfe517 Compare April 25, 2022 16:27
@wesleyboar wesleyboar marked this pull request as ready for review April 25, 2022 23:01
@wesleyboar wesleyboar merged commit ab1d91a into main Apr 25, 2022
@wesleyboar wesleyboar deleted the task/ECEP-114-nav-component branch April 25, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant