ECEP-114: Members Page (Nav Pattern, Typography, Sticky Position) #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om:TACC/Core-CMS into task/ECEP-114-states-members-page-patterns
…CEP-114-members-page-and-supporting-core-changes
wesleyboar
changed the title
wesleyboar
commented
Mar 17, 2022
taccsite_cms/static/site_cms/css/src/_imports/components/django.cms.css
Outdated
Show resolved
Hide resolved
wesleyboar
changed the title
wesleyboar
changed the title
wesleyboar
commented
Mar 17, 2022
taccsite_cms/static/site_cms/css/src/_imports/objects/o-section.css
Outdated
Show resolved
Hide resolved
… of github.com:TACC/Core-CMS into task/ECEP-114-members-page-and-supporting-core-changes
taoteg
approved these changes
Apr 14, 2022
There was a problem hiding this comment.
Everything looks good and works as advertised.
I found one thing that I have a question about, maybe nothing.
Approving as is, but feel free to tweak if this detail matters.
When the screen is on mobile layout (the navbar is collapsed and the view is < 768px wide) there are two potential issues I saw.
- At ~748.75px wide, the sticky navbar remains "tall" but shifts into the "wrapped" position (above the content).
- In both the rendered state above, and once the sticky nav window properly "wraps" itself, the content seems to be too close to the sticky nav window. Should some extra padding/margin be inserted under the "wrapped" layout?
Otherwise, looks good!
|
Cool. I'll fix 'em. 👍 |
wesleyboar
added a commit
to TACC/Core-Styles
that referenced
this pull request
Apr 25, 2022
for ECEP-114; tested in TACC/Core-CMS#464
This was referenced Apr 25, 2022
wesleyboar
added a commit
to TACC/Core-Styles
that referenced
this pull request
Apr 25, 2022
for ECEP-114; tested in TACC/Core-CMS#464
wesleyboar
added a commit
to TACC/Core-Styles
that referenced
this pull request
Apr 25, 2022
for ECEP-114; tested in TACC/Core-CMS#464
wesleyboar
added a commit
to TACC/Core-Styles
that referenced
this pull request
Apr 25, 2022
wesleyboar
added a commit
to TACC/Core-Styles
that referenced
this pull request
Apr 25, 2022
wesleyboar
added a commit
to TACC/Core-Styles
that referenced
this pull request
Apr 25, 2022
wesleyboar
added a commit
to TACC/Core-Styles
that referenced
this pull request
Apr 25, 2022
this fixes build error about missing c-nav stylesheet
|
Merge conflicts resolved. Nav responsiveness is fixed.
Vertical space between nav and content is fixed.
|
wesleyboar
deleted the
task/ECEP-114-members-page-and-supporting-core-changes
branch
wesleyboar
added a commit
to TACC/Core-Styles
that referenced
this pull request
Apr 25, 2022
* feat(ECEP-114): nav component tested in TACC/Core-CMS#464 * fix(ECEP-114): nav should go mobile at wider width * fix(ECEP-114): larger nav link click area * fix(ECEP-114): larger no list nav link click area * fix(ECEP-114): remove whitespace between nav links * fix(ECEP-114): indenting, wrapping, spacing * refactor(ECEP-114): rename indent variables
wesleyboar
added a commit
to TACC/Core-Styles
that referenced
this pull request
Apr 25, 2022
wesleyboar
commented
May 20, 2022
Comment on lines
+76
to
+79
| // Whether to wrap the starter element first | ||
| // if ( opts.mustWrapStarter ) { | ||
| // wrapper.prepend( starter ); | ||
| // } |
There was a problem hiding this comment.
@wesleyboar, should this be uncommented? If so, should then be re-tested? If not, should option be deleted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Support new ECEP CMS's Members page.
Related
* @wesleyboar realized and noted this on 2023-04-24. There may be more.
Changes
<nav>tag &c-nav...classes to Style plugin.o-sectionhack so sticky elements will work.--cms-toolbar-height.<li>,<hr>and<h4>—<h6>.Screenshots
Please see live demo of Core Nav Pattern (dev) and Core Typography (dev) and ECEP Members Page (prod) instead.
Nav Responsiveness
Testing
Nav Pattern in Isolation
Core Typography (dev)[^4] changes.* If you want to test locally, then create these snippets (click to reveal):
in Context / on ECEP Page
Build/Deploy Jobs
Footnotes
If you want to test locally, then re-create the page via
djangocms-transfer.3 ↩The heading font ("Helvetica Neue") for "Alliance Members" was a "not a design requirement, just a byproduct of the 5min mockup". ↩
For CMS access, first login to ECEP Portal, then ping @taoteg or @tacc-wbomar for CMS edit access. ↩