feat(ecep-113): style news & related patterns #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit b77d983 Author: Wesley Bomar <wbomar@tacc.utexas.edu> Date: Mon Apr 11 13:23:41 2022 -0500 fix(component): pagination
commit cec544c Author: Wesley Bomar <wbomar@tacc.utexas.edu> Date: Mon Apr 11 13:24:15 2022 -0500 fix(component): buttons
to avoid conflict with pagination --item-buffer
- new selector --article - new property --row-one-areas - hide * if `.app-blog.no-*`
even if it adds superfluous specificity
revert 21c3a2d which actually broke the selector
so that header can shrink on mobile
This reverts commit efdc213.
wesleyboar
force-pushed
the
task/ECEP-113-support-news
branch
from
2a2d42d to
54ebdac
Compare
I will replace them via JavaScript in Core-CMS.
and delete cms-specific selectors already in core-cms
Split the generics/figures into: 1. elements/figure 2. components/bootstrap.figure (extends the former)
This reverts commit ca82444.
wesleyboar
commented
Apr 29, 2022
Comment on lines
-1
to
-11
| /* | ||
| Django CMS Blog Components | ||
|
|
||
| Components for [Django CMS Blog](https://djangocms-blog.readthedocs.io) UI. These classes are authored in templates of third-party origin, but they have no third-party styles. | ||
|
|
||
| Reference: | ||
|
|
||
| - [Django CMS Blog `.blog-` Class Components](https://github.com/TACC/CORE-cms/tree/main/taccsite_cms/templates/djangocms_blog) | ||
|
|
||
| Styleguide Components.DjangoCMS.Blog | ||
| */ |
There was a problem hiding this comment.
(copied file to TACC/Core-CMS:/taccsite_cms/static/site_cms/css/src/…)
Comment on lines
+113
to
+116
| p { | ||
| margin-bottom: 2rem; /* overwrite Bootstrap */ | ||
| } | ||
|
|
There was a problem hiding this comment.
Note. This style—and this whole file—could be considered CMS-specific, in which case it should move to Core-CMS via TACC/Core-CMS#482, but I just haven't confirmed whether either (this code or this whole file) is CMS-specific yet, because the Docs could also use such basic html element styles.
There was a problem hiding this comment.
Seems reasonable to leave it here until you are sure. =)
Comment on lines
-1
to
-11
| /* | ||
| Django CMS Blog Post Components | ||
|
|
||
| Components for [Django CMS Blog Post](https://djangocms-blog.readthedocs.io) UI. These classes are authored in templates of third-party origin, and expanded by us, but they have no third-party styles. | ||
|
|
||
| Reference: | ||
|
|
||
| - [Django CMS Blog `.post-` Class Components](https://github.com/TACC/CORE-cms/tree/main/taccsite_cms/templates/djangocms_blog) | ||
|
|
||
| Styleguide Components.DjangoCMS.Post | ||
| */ |
There was a problem hiding this comment.
(merged file into TACC/Core-CMS:/taccsite_cms/static/site_cms/css/src/… which then split its styles into multiple stylesheets)
| [class*="o-offset-content--"] { | ||
| max-width: 50%; | ||
| :--o-offset-content { | ||
| max-width: 560px; | ||
| } |
There was a problem hiding this comment.
The offset content changes support the use of c-offset-content--right on many ECEP news articles.
ECEP Articles Using this Pattern
- https://prod.ecep.tacc.utexas.edu/news/2021/02/25/cape-framework-published-communications-acm/
- https://prod.ecep.tacc.utexas.edu/news/2019/09/13/2019-state-computer-science-education-report-released/
- https://prod.ecep.tacc.utexas.edu/news/2017/11/15/ecep-alliance-shares-commitment-csforall-summit/
- https://prod.ecep.tacc.utexas.edu/news/2017/08/31/puerto-rico-set-teach-exploring-computer-science-spanish/
- https://prod.ecep.tacc.utexas.edu/news/2017/07/26/ecep-website-redesign-focus-access-content-and-design/
- https://prod.ecep.tacc.utexas.edu/news/2017/05/04/nv-nh-nc-pr-awarded-mini-grants-further-cs-education-equity/
- https://prod.ecep.tacc.utexas.edu/news/2017/02/01/rethinking-perkins-expand-access-k-12-computer-science/
taoteg
approved these changes
May 2, 2022
wesleyboar
commented
May 2, 2022
|
|
||
| Styleguide Components.Bootstrap.Pagination | ||
| */ | ||
| @import url("@tacc/core-styles/source/_imports/components/c-page.css"); |
There was a problem hiding this comment.
Hint: This imported stylesheet was added in #5.
|
All related PR have been approved. I merge now. |
wesleyboar
changed the title
This was referenced Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Make changes to support ECEP News.
Related
Changes
Screenshots & Testing
See TACC/Core-CMS#466.
Notes
This PR was broken into smaller ones to track isolated changes separately.