Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis should turn red when unit tests fail #194

Merged
merged 2 commits into from
Jan 23, 2019
Merged

Travis should turn red when unit tests fail #194

merged 2 commits into from
Jan 23, 2019

Conversation

rijobro
Copy link
Contributor

@rijobro rijobro commented Jan 23, 2019 •
edited
Loading

Addresses #192.

@casperdcl casperdcl self-assigned this Jan 23, 2019
@rijobro
Copy link
Contributor Author

rijobro commented Jan 23, 2019

@casperdcl the docker builds are still red on travis. Is this intentional?

https://travis-ci.org/CCPPETMR/SIRF-SuperBuild/builds/483407696

@casperdcl
Copy link
Member

hmm the last successful docker push according to https://hub.docker.com/r/ccppetmr/sirf/tags was 2 days ago - has anything changed in the testing framework changed over the last couple of days? If so that would probably have to be duplicated in the docker build scripts...

@casperdcl
Copy link
Member

ah these are two separate issues. let's merge #194 and open a new one for docker elsewhere

@casperdcl
Copy link
Member

basically this is intentional (security) but has led me to discover a separate issue (#195)

@rijobro rijobro merged commit 789afbd into SyneRBI:master Jan 23, 2019
@rijobro rijobro deleted the fix_travis branch January 23, 2019 17:23
@KrisThielemans
Copy link
Member

fine to merge this

@casperdcl casperdcl mentioned this pull request Feb 27, 2019
Merged
7 tasks
casperdcl added a commit that referenced this pull request Mar 2, 2019
@casperdcl
Merge branch 'docker'
6a896c5 
- fixes #194
- fixes #195
- reverts #209
- closes #214
- depends on #212 -> #213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@casperdcl casperdcl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rijobro @casperdcl @KrisThielemans