-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis fails but stays green #192
Comments
I think these are unrelated, as they are for cases that are expected to fail, so we want to return the opposite of the exit code of the script. In the case of Gadgetron, if the test fails, we want to report that it fails. Since the ctest fails, but travis is happy, my guess is that the answer lies in the way we've set up the |
I guess this then needs
in the .travis.yml |
Ok, waiting to see what travis has to say about that: https://travis-ci.org/CCPPETMR/SIRF-SuperBuild/builds/483358628. |
doesn't explain why SIRF fails without needing the |
This seems to fix it (link), but also shows up the docker builds in red. @casperdcl is this normal? |
ah I didn't look at the correct |
This has started happening again. Most recent error that should be causing it to be red happened during the
|
on what OS? |
both unfortunately... |
we won't update Travis things anymore |
closes SyneRBI#192 closes SyneRBI#181
Travis shows that all builds are green for the Superbuild (e.g., most recent build).
However, if you check one of the OSX builds (e.g., this one), you'll notice:
These tests are also failing on SIRF, but they are actually showing up as having failed (e.g., link).
The reason they should be red is that they are failing the Gagetron unit tests (added in PR #182). This is a problem to be addressed elsewhere, but Travis should be flagging up the fact that it fails.
The text was updated successfully, but these errors were encountered: