Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docker & ccache #214

Merged
merged 16 commits into from
Mar 2, 2019
Merged

fix docker & ccache #214

merged 16 commits into from
Mar 2, 2019

Conversation

casperdcl
Copy link
Member

@casperdcl casperdcl commented Feb 27, 2019

depends on #212 -> #213

@casperdcl casperdcl changed the title Docker fix docker & ccache Feb 27, 2019
@casperdcl casperdcl self-assigned this Feb 27, 2019
@casperdcl casperdcl added this to the v2.0 milestone Feb 27, 2019
@casperdcl
Copy link
Member Author

ok now getting (https://api.travis-ci.org/v3/job/499919417/log.txt):

test 3
    Start 3: Gadgetron_TESTS
...
3: 1: [  FAILED  ] 2 tests, listed below:
3: 1: [  FAILED  ] hoNDArray_blas_Cplx/0.nrm2Test, where TypeParam = std::complex<float>
3: 1: [  FAILED  ] hoNDArray_blas_Cplx/2.nrm2Test, where TypeParam = Gadgetron::complext<float>

@KrisThielemans
Copy link
Member

hmmm. strange as 18.04 is their reference system.

I'll try to see in a VM if I can reproduce this. Only possibly reason that I see is the addition of the two CBLAS lines when building Gadgetron? sorry. not really what you want to have to fix.

@casperdcl
Copy link
Member Author

casperdcl commented Mar 1, 2019

Turns out libatlas-base-dev was required (#195 (comment)) even though their List of Dependencies does not mention it.

In the end I just used https://github.com/gadgetron/gadgetron/blob/b03e500/docker/base/ubuntu_1804/Dockerfile#L8-L10

docker/build_system-ubuntu.sh Outdated Show resolved Hide resolved
docker/build_system-ubuntu.sh Outdated Show resolved Hide resolved
docker/build_system-ubuntu.sh Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
docker/build_system-ubuntu.sh Outdated Show resolved Hide resolved
docker/build_system-ubuntu.sh Outdated Show resolved Hide resolved
docker/user_sirf-ubuntu.sh Outdated Show resolved Hide resolved
Copy link
Member

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could presumably later use docker/build_essential-ubuntu.sh in Travis (and of course VM etc etc), except that we might need to pass location as not everyone will be able to write in /opt

@casperdcl casperdcl merged commit dbc65af into master Mar 2, 2019
casperdcl added a commit that referenced this pull request Mar 2, 2019
- fixes #194
- fixes #195
- reverts #209
- closes #214
- depends on #212 -> #213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix docker builds
2 participants