Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit and e2e tests #193

Merged
merged 6 commits into from
Jun 18, 2024
Merged

Add unit and e2e tests #193

merged 6 commits into from
Jun 18, 2024

Conversation

nyandika
Copy link
Contributor

Have you read the contributing guidelines ?
Yea

What is the purpose of your pull request?

  • Bug fix
  • New feature

Proposed changes

Adding unit tests using vitest. Codebase already uses vite to build so this should be a straightforward choice
Adding e2e tests using playwright. it is feature rich, cross-browser support and supports multiple languages

I have added sample tests for these two

Also added github actions for tests and validation.
This will fail as there are several files that violate linting and formatting. These files can be fixed gradually.
I chose not to at this time as there are significantly several files to be touched which will render this PR hard to review and out of scope

Warning

Please read these points carefully and answer honestly with an X
into all the boxes. Example : [X]

Before submitting a pull request make sure you have:

  • Read the guidelines for contributing.
  • Wrote some tests.
  • Respected the linting guidelines.

Copy link

vercel bot commented Jun 15, 2024

@nyandika is attempting to deploy a commit to the sytweb Team on Vercel.

A member of the Team first needs to authorize it.

@JimmyTron JimmyTron enabled auto-merge June 17, 2024 07:44
@sonylomo sonylomo disabled auto-merge June 18, 2024 08:04
@sonylomo sonylomo changed the base branch from main to Dev June 18, 2024 10:35
@sonylomo sonylomo requested a review from alvyynm June 18, 2024 10:37
@Ase020 Ase020 merged commit 65890ac into SpaceyaTech:Dev Jun 18, 2024
1 of 2 checks passed
@nyandika nyandika deleted the nyandika/testing branch June 18, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants