Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick a testing framework #191

Closed
alvyynm opened this issue Jun 13, 2024 · 4 comments
Closed

Pick a testing framework #191

alvyynm opened this issue Jun 13, 2024 · 4 comments

Comments

@alvyynm
Copy link
Member

alvyynm commented Jun 13, 2024

A recent commit to the main branch has added a PR template.

One of the requirements is to include tests when adding a new feature. However, it seems we haven't decided on an appropriate testing framework to be used. I suggest we settle on one to avoid conflicts in the future.

@alvyynm
Copy link
Member Author

alvyynm commented Jun 14, 2024

Thoughts? @sonylomo

@sonylomo
Copy link
Collaborator

Testing hasn't been a major priority because we were short handed.

However, I'm open to the idea. I'll do my research and we can settle on a testing tool to use. 🙂

@nyandika
Copy link
Contributor

I haven't contributed in this space for what looks like eons but I had time today.

I have a pull request #193 testing this out.

I have gone with vitest for unit tests and playwright for end-to-end tests

please review and we can discuss merits and shortcomings of both and other alternatives

@sonylomo
Copy link
Collaborator

Thank you @nyandika for your contribution. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants