Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting and formatting checks are ever failing #212

Closed
3 tasks
alvyynm opened this issue Jul 8, 2024 · 3 comments
Closed
3 tasks

Linting and formatting checks are ever failing #212

alvyynm opened this issue Jul 8, 2024 · 3 comments

Comments

@alvyynm
Copy link
Member

alvyynm commented Jul 8, 2024

Since proper linting and formatting checks were added in #193, all of them have always failed. We should start addressing this. From build previews, the key issue we have is code formatting and linting (formatting is an easy fix but the latter requires a little bit of work to the codebase because it's manual).

We have checks in place for both in package.json, and we need to start enforcing these standards before approving PRs. So before someone's PR is approved, they should, among other things, run the prettier:format and lint scripts in package.json (added in #193).

That way, one gets a chance to fix these before blindly making a PR. We should also update the PR template to let everyone know while making a PR.

Tasks:

  • Fix linting issues
  • Fix formatting issues
  • Update PR template
@alvyynm
Copy link
Member Author

alvyynm commented Jul 8, 2024

@sonylomo, @bridgitkanini, @Ase020, @JimmyTron what do you guys think?

@sonylomo
Copy link
Collaborator

sonylomo commented Jul 8, 2024

As long as you're the one fixing it 😃

@alvyynm
Copy link
Member Author

alvyynm commented Jul 9, 2024

Yes, I'll work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants