Allow JAEGER_AGENT_PORT env on default Jaeger configuration #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masroor Hasan <masroor.hasan.n@gmail.com>
|
Now that I'm thinking about it more, exposing other Jaeger config params like service name, sampler type/param via environment variable seems it would further improve flexibility. I could add it part of this PR, thoughts @cliveseldon ? |
ukclivecox
approved these changes
Jan 20, 2019
|
Thanks! |
agrski
pushed a commit
that referenced
this pull request
Dec 2, 2022
* initial mtls scheduler server commit * rewrite tls with renew and secret and folder handlers * scheduler mtls * add TLS to hodometer * add docs * cli docs * lint * lint * test fix lint * remove use of ioutil * hodometer lint * fix components lint * increase timeout on lint * make lint version same * review comments * ignore cover.out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: #396
Allows
JAEGER_AGENT_PORTto be set on deployment manifest to expose specific Jaeger agent port.