Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow JAEGER_AGENT_PORT env on default Jaeger configuration #397

Merged
merged 2 commits into from
Jan 20, 2019
Merged

Allow JAEGER_AGENT_PORT env on default Jaeger configuration #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00a890c
expose jaeger agent port as env var with existing defaults
masroorhasan Jan 14, 2019
f9411bc
update docs for JAEGER_AGENT_PORT
masroorhasan Jan 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/distributed-tracing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ You will need to annotate your Seldon Deployment resource with environment varia

Add an environment variable: TRACING with value 1 to activate tracing.

You can utilize the default configuration by simply providing the name of the Jaeger agent service by providing JAEGER_AGENT_HOST environment variable.
You can utilize the default configuration by simply providing the name of the Jaeger agent service by providing JAEGER_AGENT_HOST environment variable. Override default Jaeger agent port `5775` by setting JAEGER_AGENT_PORT environment variable.

To provide a custom configuration following the Jarger Python configuration yaml defined [here](https://github.com/jaegertracing/jaeger-client-python) you can provide a configmap and the path to the YAML file in JAEGER_CONFIG_PATH environment variable.

Expand Down
3 changes: 2 additions & 1 deletion python/seldon_core/microservice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,7 @@ def main():
from jaeger_client import Config

jaeger_serv = os.environ.get("JAEGER_AGENT_HOST","0.0.0.0")
jaeger_port = os.environ.get("JAEGER_AGENT_PORT", 5775)
jaeger_config = os.environ.get("JAEGER_CONFIG_PATH",None)
if jaeger_config is None:
logger.info("Using default tracing config")
Expand All @@ -333,7 +334,7 @@ def main():
},
'local_agent': {
'reporting_host': jaeger_serv,
'reporting_port': 5775,
'reporting_port': jaeger_port,
},
'logging': True,
},
Expand Down