You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The default configuration for Jaeger tracing allows specifying jaeger agent host address but hardcodes port 5775 (for zipkin.thrift over thrift protocol).
The default seldon python deployment should expose enabling the agent port through environment variable so users can pick the right port to configure clients (for example, 6831).
Setting that with configuration YAML mounted on config map does not cover all use cases of setting host and port. For example, Jaeger agent works best deployed as a Daemonset on each Node, with deployments scheduled on Node only needs to send data to its local agent. Setting status.hostIP on the data in a config map is not supported native (could mount and sed update the value but that seems like a hack).
Basically, proposing to support this on a seldon deployment:
* Use Distroless Debian11 for Hodometer image
* Use Distroless Debian11 for Hodometer stub receiver image
* Use Distroless static for Hodometer images
* Use nonroot Distroless images for Hodometer
* Use nonroot Distroless images for SCv2 core Go components
* Use Debian-based Distroless image for core Go components
These components are buit with Kafka, which uses librdkafka under the hood.
In turn, this is highly likely to be dynamically linked to a C/C++ runtime,
meaning we need an image which contains this C/C++ dependency.
* Disable CGo for scheduler container build
This successfully allows the scheduler container to start in Compose.
* Change scheduler base image back to static Distroless
* Disable CGo for agent images & use static Distroless image as base
* Disable CGo for scheduler, agent, and proxy scheduler binaries in Makefile
* Add Dockerfile comments re use of specific base images for built binaries
* Use entrypoint instead of cmd in Dockerfiles
The default configuration for Jaeger tracing allows specifying jaeger agent host address but hardcodes port
5775
(for zipkin.thrift over thrift protocol).However, Jaeger agent exposes multiple UDP ports to support jaeger.thrift and binary thrift as well: https://www.jaegertracing.io/docs/1.8/deployment/#agent
The default seldon python deployment should expose enabling the agent port through environment variable so users can pick the right port to configure clients (for example,
6831
).Setting that with configuration YAML mounted on config map does not cover all use cases of setting host and port. For example, Jaeger agent works best deployed as a
Daemonset
on each Node, with deployments scheduled on Node only needs to send data to its local agent. Settingstatus.hostIP
on the data in a config map is not supported native (could mount andsed
update the value but that seems like a hack).Basically, proposing to support this on a seldon deployment:
Proposed change: master...masroorhasan:masroor/jaeger-port
If the above change is ok, I'd like to submit a PR (pending discussion on the change). I assume docs and example would need to be updated as well.
Thanks!
The text was updated successfully, but these errors were encountered: