Enable UGRID loading always; deprecate PARSE_UGRID_ON_LOAD. #6054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
N.B. now requires SciTools/iris-test-data#92 |
pp-mo
force-pushed
the
ugrid_load_default
branch
from
f84ab0d
to
97f47d0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6054 +/- ##
==========================================
- Coverage 89.76% 89.75% -0.01%
==========================================
Files 90 90
Lines 22991 22981 -10
Branches 5030 5026 -4
==========================================
- Hits 20638 20627 -11
- Misses 1623 1624 +1
Partials 730 730 ☔ View full report in Codecov by Sentry. |
pp-mo
force-pushed
the
ugrid_load_default
branch
from
7b53831
to
ce621f8
Compare
|
Thanks @stephenworsley ! |
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Jul 30, 2024
* upstream/main: Load performance improvement (ignoring UGRID) (SciTools#6088) Adding monthly and yearly arguments to `guess_bounds` (SciTools#6090) Mesh nonexperimental extra (SciTools#6077) Mesh nonexperimental (SciTools#6061) Bump scitools/workflows from 2024.07.4 to 2024.07.5 (SciTools#6076) Updated environment lockfiles (SciTools#6068) Enable UGRID loading always; deprecate PARSE_UGRID_ON_LOAD. (SciTools#6054) Bump scitools/workflows from 2024.07.3 to 2024.07.4 (SciTools#6071)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5940
N.B. does not anticipate #6057
That could affect this a bit, and will probably involve a bunch more deprecations.