Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'node_coordinates' in theta_nodal_not_ugrid.nc #92

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Jul 17, 2024

See SciTools/iris#6054

With these changes, Iris will load this file "as-was" (i.e. without UGRID loading enabled),
since we are now permanently enabling ugrid loading.

Renamed the "node_coordinates" attribute of "Mesh0" to "NOT_node_coordinates",
since otherwise the "Mesh0_node_x" and "Mesh0_node_y" are identified as "CFAuxiliaryCoordinateVariable"s,
and this prevents them becoming regular aux-coords, which is required for these tests to function.

Copy link

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@stephenworsley stephenworsley merged commit f724cc6 into SciTools:master Jul 19, 2024
1 check passed
@pp-mo
Copy link
Member Author

pp-mo commented Jul 19, 2024

Looks good.

Thanks !
I'll respin SciTools/iris#6054 and we'll see how that goes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants