Load performance improvement (ignoring UGRID) #6088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenworsley
added
the
benchmark_this
* main: Mesh nonexperimental extra (SciTools#6077) Mesh nonexperimental (SciTools#6061) # Conflicts: # lib/iris/experimental/ugrid/cf.py
stephenworsley
added
benchmark_this
⏱️ Performance Benchmark Report: 609d5d2Performance shiftsFull benchmark resultsGenerated by GHA run |
|
Initial benchmark results are interesting. not all straightforward. |
pp-mo
added
benchmark_this
WHOOPS sorry, I did that to the wrong PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6088 +/- ##
=======================================
Coverage 89.77% 89.77%
=======================================
Files 88 88
Lines 23011 23026 +15
Branches 5032 5036 +4
=======================================
+ Hits 20657 20672 +15
Misses 1623 1623
Partials 731 731 ☔ View full report in Codecov by Sentry. |
stephenworsley
added
benchmark_this
⏱️ Performance Benchmark Report: 621b9b8Performance shiftsFull benchmark resultsGenerated by GHA run |
⏱️ Performance Benchmark Report: fd30e4dPerformance shiftsFull benchmark resultsGenerated by GHA run |
stephenworsley
changed the title
bjlittle
requested changes
Jul 29, 2024
There was a problem hiding this comment.
@stephenworsley Looks good! 💯
Just a couple of comments to service, then we can bank this 👍
Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>
bjlittle
approved these changes
Jul 29, 2024
* main: Adding monthly and yearly arguments to `guess_bounds` (SciTools#6090)
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Jul 30, 2024
* upstream/main: Load performance improvement (ignoring UGRID) (SciTools#6088) Adding monthly and yearly arguments to `guess_bounds` (SciTools#6090) Mesh nonexperimental extra (SciTools#6077) Mesh nonexperimental (SciTools#6061) Bump scitools/workflows from 2024.07.4 to 2024.07.5 (SciTools#6076) Updated environment lockfiles (SciTools#6068) Enable UGRID loading always; deprecate PARSE_UGRID_ON_LOAD. (SciTools#6054) Bump scitools/workflows from 2024.07.3 to 2024.07.4 (SciTools#6071)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Attempts to address performance slowdowns highlighted here #6075