-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow parameters to be unknowns in the initialization system #2928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 6, 2024
AayushSabharwal
force-pushed
the
as/param-init
branch
3 times, most recently
from
August 21, 2024 08:50
b2cff45
to
86980c2
Compare
5 tasks
AayushSabharwal
force-pushed
the
as/param-init
branch
from
September 4, 2024 11:03
86980c2
to
4495721
Compare
Note to self: test all of the namespacing edgecases handled here
|
AayushSabharwal
force-pushed
the
as/param-init
branch
2 times, most recently
from
September 6, 2024 15:42
8080def
to
8449c12
Compare
AayushSabharwal
force-pushed
the
as/param-init
branch
from
September 16, 2024 07:31
8449c12
to
ceb4e9c
Compare
5 tasks
AayushSabharwal
force-pushed
the
as/param-init
branch
from
September 26, 2024 13:56
d85ed68
to
431d270
Compare
AayushSabharwal
force-pushed
the
as/param-init
branch
from
October 8, 2024 11:20
e774ea2
to
233086b
Compare
Thank god, the rebase worked |
AayushSabharwal
force-pushed
the
as/param-init
branch
from
October 9, 2024 12:20
233086b
to
c3487a5
Compare
…ke_initializeprob`
AayushSabharwal
force-pushed
the
as/param-init
branch
from
October 10, 2024 07:20
8c25e7d
to
84a1f2e
Compare
Thanks for all the hard work that went into this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't dev
OrdinaryDiffEq
locally for some reason: it isn't able to find a version ofOrdinaryDiffEqSDIRK
(and others). However, running the tests withOrdinaryDiffEqTsit5
andOrdinaryDiffEqNonlinearSolve
dev'd works.Requires
setp
, refactorremake_buffer
SymbolicIndexingInterface.jl#92 for the out-of-placesetp
initializeprobpmap
in relevantSciMLFunctions
SciMLBase.jl#760 for the modifications toODEFunction
initialize_dae!
OrdinaryDiffEq.jl#2314 for using the newinitializeprobpmap
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.