Clean up generate_initializesystem() #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this looks amazing! I can very easily rebase the parameter initialization on top of this, so it shouldn't need to wait. |
|
Could you rebase this? Would love to get this merged |
|
Sure, I will do my best when I get back next week :) |
hersle
force-pushed
the
cleanup_initialization
branch
from
847237d
to
a61977a
Compare
|
I tried to improve and simplify the handling of vector equations and scalarization a bit. |
hersle
force-pushed
the
cleanup_initialization
branch
from
11c335a
to
09fda2f
Compare
|
Tests seem to pass. |
|
Is that failure on master? |
|
Yes, looks like it. |
| kwargs...) | ||
| sts, eqs = unknowns(sys), equations(sys) | ||
| guesses = Dict(), | ||
| default_dd_guess = 0.0, |
There was a problem hiding this comment.
Is the old name documented anywhere?
ChrisRackauckas
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #3050, I found
generate_initializesystem()a little hard to follow. I thought I could try to clean it up a little, after it has accumulated several fixes recently.Please feel free to ignore this if it is not helpful. I know @AayushSabharwal is working on parameter initialization, so I wouldn't want this merged before if it clutters that!
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.