-
Notifications
You must be signed in to change notification settings - Fork 103
Add constructors and operators #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add a branch for MSVC compiler flags in tests\CMakeLists.txt
instead of type conversion from initializer list. MSVC does not allow this type of conversion.
MSVC build fix
This is absolutely fantastic! Thanks so much for pushing it forwards. Is there anything else you think we should get in there before merging? |
Co-authored-by: Rob Loach <robloach@gmail.com>
Idk, nothing really comes to my mind right now. |
Also as a general note, not necessarily related to this PR, it would be neat if all the methods that take |
Also have you maybe considered using some framework for the tests? |
Having
Catch2 use to be in there, but took it out because it was causing issue with some compilers. |
I don't think string view would be a good match here. String view is good for efficiently referencing parts of other, existing string. I think plain old |
Added constructors and assigmnent operators according to the rule of five to all other classes that needed it (according to the appropriate Unload*() functions found in raylib).
Also some cosmetic fixes:
NULL
withnullptr
ModelAnimation::Load
method