Skip to content

MSVC build fix #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 27, 2021
Merged

MSVC build fix #140

merged 2 commits into from
Aug 27, 2021

Conversation

Mahno9
Copy link
Contributor

@Mahno9 Mahno9 commented Aug 26, 2021

Fix for both #139 issues:

  1. MSVC compiler flags has been added as a branch to tests\CMakeLists.txt.
  2. Initializer list has constructor has been used instead of type conversion from initializer list.

Changes has been tested with WSL gcc 9.3.0 and MSVC 14.29.30133

Mahno9 added 2 commits August 26, 2021 15:45
@Mahno9
Adopt compiler flags for MSVC
8ddc4e0 
Add a branch for MSVC compiler flags in tests\CMakeLists.txt
@Mahno9
Use initializer list constructor
db4ed5a 
instead of type conversion from initializer list.
MSVC does not allow this type of conversion.
@Mahno9 Mahno9 mentioned this pull request Aug 26, 2021
Closed
@Mahno9 Mahno9 changed the title Msvc build fix MSVC build fix Aug 26, 2021
@RobLoach RobLoach merged commit c7c0b67 into RobLoach:master Aug 27, 2021
@Mahno9 Mahno9 deleted the MSVC-build-fix branch September 12, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mahno9 @RobLoach