-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add name="crx" attribute for URL input in crxviewer.html #99
Comments
What's the use case for keyword registration of this tool? Are you using the online demo or the extension? I recommend to use the extension over the online version, because the extension is faster and has less limitations (e.g. it can be used to view the source of extensions/zip files that are behind cookies). The online version relies on a proxy, which is slower and sometimes unavailable. |
The excellent "online demo" (Naturally, if usage of the extension is preferred due dangers of increased costs of running the web app on your side, I'll install the extension and forget the app immediately, just tell.)
Like any other keyword search: fast navigation and URL placeholder expansion. In this case it would just save user from copypasting URL into input, so they could invoke the on relevant page instead. This change would just ensure that keyword search bookmark created from context menu on the input field would match actual functionality of the app: "details" page that expects the Actual use case of his certain keyword search, if it isn't clear already: Creation
Usage
So the Usage outcome is quite identical to |
Well to be fair I also sometimes just type my website because it takes less effort than trying to open the extension page.
Regardless of the cost of serving the web app, I would still recommend to use the extension because the user-perceived performance is better. I use CORS Anyhwere as a proxy (which I also created), which is quite popular, to the extent that it is sometimes down due to the high usage. Using the extension allows the browser to make a direct request, which increases the speed of loading. In the next update of crxviewer, I'll remove the use of the proxy for Firefox add-ons, because the proxy is no longer needed due to the fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1620084. Other sources of extensions will still need the proxy when the online web app is used, though.
Sounds reasonable. And like I said, I totally understand your desire for this feature. And since adding an extra attribute to the HTML file isn't really a burden, I am also willing to accept a pull request that adds the attribute. |
- Rely on CORS instead of work-arounds for public XPI files from AMO (#92) - Add work-around for crx access in Brave (#91) - Support source viewing of extensions from Microsoft Edge (#95) - Remove web_accessible_resourced to avoid UUID leak (#100) - Correct 0-padding of hashes (#104) - Update jsbeautifier to v1.14.0 (#110) - Support source viewing of extensions from Thunderbird (#111) - Fix domain front of AMO in Firefox add-on (#115) - Recognize CRX3 files served by addons.opera.com (#118) - Opera only: Add work-around to access addons.opera.com (#119) - web only: Add crx keyword to input field for keyword search (#99) - web only: Avoid breakage of web version when an extension runs a script (#113) - Refactor: remove unsupported declarativeWebRequest path - Refactor: Use declarative page actions to show button.
I've included this change in the latest version at https://robwu.nl/crxviewer/. |
so that user action "Add a Keyword for this Search" worked as expected in Firefox. (Presumably would help Chrome understand it better as well.)
crxviewer/src/crxviewer.html
Line 66 in be2e258
The text was updated successfully, but these errors were encountered: