Stopped working with Brave

[mikhoul]

When I try to look at a source:

Console:

Regards

[mikhoul]

Same thing happen when I try to download a source:

[mikhoul]

Here the sanitized HAR file:
redacted_jifpbeccnghkjeaalbbjmodiffmgedin.zip

[Rob--W]

Brave unconditionally intercepts update requests to Google (even if not originating from the browser process...), and replaces it with a request to go-updater.brave.com:
https://github.com/brave/brave-core/blob/f453ab2a5e8425afea9bd980fb688d8fec137f53/browser/net/brave_common_static_redirect_network_delegate_helper.cc#L77

Someone reported this issue to me last year, but I unfortunately forgot to follow up to that.

A work-around is to replace "clients2" with "clients3" since they seem to point to the same resources.

Another workaround is to use two slashes in front of the path, since Brave's URL interception logic is based on a match pattern that is equivalent to https://clients2.google.com/service/update2/crx"* (combined with the source in Chromium).

I'll look into a way to detect Brave and add a work-around.

[gslin]

It seems Brave has changed this code, so // not working anymore (tested against master branch of crxviewer):

bool IsUpdaterURL(const GURL& gurl) {
  static std::vector<URLPattern> updater_patterns(
      {URLPattern(URLPattern::SCHEME_HTTPS,
                  std::string(component_updater::kUpdaterJSONDefaultUrl) + "*"),
       URLPattern(
           URLPattern::SCHEME_HTTP,
           std::string(component_updater::kUpdaterJSONFallbackUrl) + "*"),
#if BUILDFLAG(ENABLE_EXTENSIONS)
       URLPattern(
           URLPattern::SCHEME_HTTPS,
           std::string(extension_urls::kChromeWebstoreUpdateURL) + "*")
#endif
  });
  return std::any_of(
      updater_patterns.begin(), updater_patterns.end(),
      [&gurl](URLPattern pattern) { return pattern.MatchesURL(gurl); });
}

[Rob--W]

Could you confirm whether version 1.6.12 fixes the issue for you?

[gslin]

Cool thanks, I didn't install 1.6.12 but I installed 1.6.11 from Google official webstore and it's working...

Not sure what happened, but anyway it's a good news :-)

[Rob--W]

I'll remove the workaround with a future update then, as a cleanup.

On Brave's end this probably started working again due to the changes from brave/brave-core@b3802c6