Flightcomputer TGT orientation now correct - fixes #69 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -254,7 +254,7 @@ private void OnAttitudeClick(int state) | |||
| if (!mFlightComputer.InputAllowed) | |||
| return; | |||
| mAttitude = (state < 0) ? 0 : state; | |||
| if (mMode < 4) | |||
| if (mMode < 3) | |||
There was a problem hiding this comment.
Wow, that turned out to be simple. Though at some point we should probably replace these integer flags with proper enums.
Discussion question: in both Cilph's and Peppie23's version of the code, the flight computer will stay in CUSTOM mode (mMode = 7) when you click an attitude button. This basically amounts to the GRD+/- buttons having no effect until you manually change to a different mode. Is this desired behavior?
There was a problem hiding this comment.
This bugs the hell out of me, so I'd say no, and it should be scheduled for a fix after 1.4.0
Merged
|
Merged as part of #78 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.