1.6.0 #69
Merged
1.6.0 #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially addresses #2. Indicator does not yet support multiple omni bonus or root range model. Also renamed IAntenna.Radians to IAntenna.CosAngle, to prevent future programming errors.
Rangefinder
Replaced names like `a` and `b` with semantic names, and updated names from underscore to camel case. Also reversed order of arguments for RangeModel.GetContextRange, to bring it more in line with the RangeModelExtensions.IsTargeting* functions.
Some RT functions recognized active vessels, others did not. Now everything is consistent.
The function uses exactly the same logic as isTargetingPlanet, but no longer demands that the target be a celestial body nor that the satellite being contacted must be found in the target's SoI.
`Vector3.up` appears to be the default value of `CelestialBody.transform.up` at present, so this change should have no effect visible to the user.
Renamed a few variables that @erendrake spotted. Factored `ISatellite.this[]`. Renamed RangeModel functions to upper CamelCase, in keeping with [C# conventions](http://msdn.microsoft.com/en-us/library/ff926074.aspx).
Just realized that RangeModelExtensions is meant to have, yes, extension methods. `GetPositionFromGuid()` doesn't qualify, but it serves a similar purpose to a few other `NetworkManager` methods. Throwing an exception on invalid input is not standard for RemoteTech methods, but since Vector3d is not nullable I can't think of a good way to handle the error internally.
Consistent cones
… the two places that currently call it to handle the null value instead of handling a exception.
Nullable return
Saves the position of the window
- added a new value to the groundstations to tint the mark.png from the settings.cfg Fixes #240
Possibility to tint groundstations
Save/Restore Flightcomputer plan
- the TargetInfoWindow now opens right and not after onPositionchanged is called - deleted log spamming
Small v1.6 fixes
- removed log spamming by null target - UpdateNetworkCones now checks if the target is a target or not
- renamed all remotetech inputs with a small prefix 'rt_' - added two new methods to the AbstractWindow to handle a stacklock for focused remotetech inputs
removed dependency on task extensions
Peppie84
added a commit
that referenced
this pull request
Jan 10, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.