Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Targeting active vessel also targets body it's orbiting #13

Closed
Starstrider42 opened this issue May 26, 2014 · 7 comments · Fixed by #193
Closed

Targeting active vessel also targets body it's orbiting #13

Starstrider42 opened this issue May 26, 2014 · 7 comments · Fixed by #193

Comments

@Starstrider42
Copy link
Contributor

Original issues at Cilph/RemoteTech2#173, Cilph/RemoteTech2#183.

May be rendered obsolete by #27.

kaufman-bryce wrote:

The feature to target the active vessel is quite nice, but could be made much more powerful if that option caused the dish to aim at the planet the active vessel is orbiting as well. Alternatively, a separate option to target active body.

HoneyFox wrote:

The idea is simple, i would like to use some pseudo-codes:
if ( activeVessel.MainBody == dishIterated.Vessel.MainBody )
fallback to "ActiveVessel" logic // P2P connection logic
else
dishIterated.setTarget( ActiveVessel.MainBody ) // Cone-angle check logic

erendrake pushed a commit that referenced this issue May 30, 2014
-Added AeroProbe and AdvAeronautics (Issue #13).
-Added legacy integration to ModuleSPU (Issue #5).
-Added temporary KSPEvent to toggle the extra debug signal delay.
@Starstrider42
Copy link
Contributor Author

@RemoteTechnologiesGroup/owners, I believe that having dish cones apply consistently regardless of whether the target is a ship or celestial body (i.e., there is always a cone, and it is always centered on the current target) will make gameplay much more intuitive for new (and, apparently, not-so-new) players. I propose it be made a priority for version 1.5.0.

@Starstrider42 Starstrider42 added this to the 1.5.0 milestone Jun 28, 2014
@pjf
Copy link
Contributor

pjf commented Jun 28, 2014

++ for @Starstrider42's comment here. That's how I thought things worked until I started targeting planets and was very surprised to see cone indicator lines appear.

@erendrake
Copy link
Member

I agree. Very important
On Jun 28, 2014 1:43 PM, "Paul Fenwick" notifications@github.com wrote:

++ for @Starstrider42 https://github.com/Starstrider42's comment here.
That's how I thought things worked until I started targeting planets
and was very surprised to see cone indicator lines appear.


Reply to this email directly or view it on GitHub
#13 (comment)
.

@asdpyro
Copy link

asdpyro commented Jun 29, 2014

Also agree, cones need to be cones all the time.

@ghost ghost self-assigned this Sep 5, 2014
@ghost
Copy link

ghost commented Sep 17, 2014

@Starstrider42 I'll see if I can get this done this weekend.

@Starstrider42
Copy link
Contributor Author

It still needs more testing, but just to show that I've been busy:

(No, I'm not cheating -- the selected vessel has only one antenna on board.)

screenshot3

@Peppie84
Copy link
Member

Peppie84 commented Jan 3, 2015

Merged into v1.6

@Peppie84 Peppie84 closed this as completed Jan 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants