Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flightcomputer TGT orientation now correct - fixes #69 #72

Closed
wants to merge 1 commit into from
Closed

Flightcomputer TGT orientation now correct - fixes #69 #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/RemoteTech2/UI/AttitudeFragment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ private void OnAttitudeClick(int state)
if (!mFlightComputer.InputAllowed)
return;
mAttitude = (state < 0) ? 0 : state;
if (mMode < 4)
if (mMode < 3)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that turned out to be simple. Though at some point we should probably replace these integer flags with proper enums.

Discussion question: in both Cilph's and Peppie23's version of the code, the flight computer will stay in CUSTOM mode (mMode = 7) when you click an attitude button. This basically amounts to the GRD+/- buttons having no effect until you manually change to a different mode. Is this desired behavior?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bugs the hell out of me, so I'd say no, and it should be scheduled for a fix after 1.4.0

{
mMode = 4;
}
Expand Down