Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added github issue link to task request post call #1051

Merged
merged 4 commits into from
Dec 22, 2023

Conversation

sahsisunny
Copy link
Contributor

@sahsisunny sahsisunny commented Dec 18, 2023

Issue Ticket Number:-

Description:

In this pull request, I have addressed the issue described in #1050. The problem was related to the absence of GitHub issue ticket links for tasks created via task requests.

Is Under Feature Flag

  • Yes
  • No

Database changes

  • Yes
  • No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

  • Yes
  • No

Is Development Tested?

  • Yes
  • No

Tested in staging?

  • Yes
  • No

Add relevant Screenshot below ( e.g test coverage etc. )

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
taskRequestApi.ts 100 100 100 100
Card.tsx 38.35 47.05 37.5 38.02 ...18,123-153,205

Demo

e5122a3d-9cf5-4ed3-8a67-c70482d6cac7.mp4

Related

PR - Real-Dev-Squad/website-backend#1793

Copy link

vercel bot commented Dec 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2023 4:13pm

@vinit717
Copy link
Member

Please provide vide/screen-shot for different screen sizes

@sahsisunny sahsisunny closed this Dec 20, 2023
@sahsisunny sahsisunny force-pushed the fix/github-issue-link branch from 4c79659 to 598cb93 Compare December 20, 2023 21:46
@sahsisunny sahsisunny changed the title fix: changes github issue link fix: added github issue link to task request post call Dec 20, 2023
@vinit717
Copy link
Member

The video you provided is not show that issue is showing on task details

@sahsisunny
Copy link
Contributor Author

The video you provided is not show that issue is showing on task details

This PR only aims to send the html_url in a POST request.

@vinit717
Copy link
Member

The video you provided is not show that issue is showing on task details

This PR only aims to send the html_url in a POST request.

Yes but previously you were doing too many changes , code look fine to me just add one screen-shot.

@sahsisunny
Copy link
Contributor Author

The video you provided is not show that issue is showing on task details

This PR only aims to send the html_url in a POST request.

Yes but previously you were doing too many changes , code look fine to me just add one screen-shot.

We have replaced the previous changes with new ones. Please review the new changes.

@vinit717
Copy link
Member

The video you provided is not show that issue is showing on task details

This PR only aims to send the html_url in a POST request.

Yes but previously you were doing too many changes , code look fine to me just add one screen-shot.

We have replaced the previous changes with new ones. Please review the new changes.

Please add a screenshot of the task details page which is created via task request as this issue arises by seeing task details not display GitHub issue ticket

vinit717
vinit717 previously approved these changes Dec 21, 2023
Copy link
Member

@satyam73 satyam73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sahsisunny sahsisunny merged commit 8b9d348 into develop Dec 22, 2023
2 checks passed
@sahsisunny sahsisunny deleted the fix/github-issue-link branch December 22, 2023 16:22
@satyam73 satyam73 mentioned this pull request Jan 6, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants