fix: added github html url to task request #1793
Merged
+20
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Ajeyakrishna-k
previously requested changes
Dec 18, 2023
There was a problem hiding this comment.
Please don't transform the url which is in task requests. Task requests are not tasks, GitHub url should be present on tasks. So change/add the url in tasks document created from task requests.
- This change will BREAK multiple task requests flow.
- BREAK the GitHub issue render in task request details page
sahsisunny
force-pushed
the
fix/github-issue-link
branch
from
35fe129 to
639ca1d
Compare
satyam73
reviewed
Dec 20, 2023
satyam73
reviewed
Dec 20, 2023
sahsisunny
changed the title
10 tasks
vinit717
reviewed
Dec 22, 2023
vinit717
previously approved these changes
Dec 22, 2023
sahsisunny
dismissed
Ajeyakrishna-k’s stale review
he did not review again after some request
prakashchoudhary07
previously approved these changes
Dec 22, 2023
…ackend into fix/github-issue-link
…quad/website-backend into fix/github-issue-link
sahsisunny
dismissed stale reviews from vinit717, satyam73, and prakashchoudhary07
via
bf664bd
prakashchoudhary07
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Ticket Number:-
Description:
In this pull request, I have addressed the issue described in Real-Dev-Squad/website-status#1050. The problem was related to the absence of GitHub issue ticket links for tasks created via task requests.
Is Under Feature Flag
Database changes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
Is Development Tested?
Tested in staging?
Add relevant Screenshot below ( e.g test coverage etc. )
Demo
961f4e14-ec34-444c-8c31-d592bdf70789.mp4
Related
PR - Real-Dev-Squad/website-status#1051