refactor: helper function for transform url

Real-Dev-Squad · Dec 20, 2023 · 4c79659 · 4c79659
1 parent 057525b
commit 4c79659
Show file tree

Hide file tree

Showing 5 changed files with 32 additions and 32 deletions.
diff --git a/__tests__/Unit/utils/transformGitHubApiUrl.test.ts b/__tests__/Unit/utils/transformGitHubApiUrl.test.ts
diff --git a/__tests__/Unit/utils/extractRepoName.test.ts → __tests__/Unit/utils/urlTransform.test.ts b/__tests__/Unit/utils/extractRepoName.test.ts → __tests__/Unit/utils/urlTransform.test.ts
@@ -1,4 +1,23 @@
-import extractRepoName from '../../../src/utils/extractRepoName';
+import {
+    extractRepoName,
+    transformGitHubApiUrl,
+} from '../../../src/utils/urlTransform';
+
+describe('Unit | Util | Transform GitHub Api Url', () => {
+    test('returns proper value with proper input', () => {
+        expect(
+            transformGitHubApiUrl(
+                'https://api.github.com/repos/Real-Dev-Squad/todo-action-items/issues/196'
+            )
+        ).toEqual(
+            'https://github.com/Real-Dev-Squad/todo-action-items/issues/196'
+        );
+    });
+
+    test('returns # with improper input', () => {
+        expect(transformGitHubApiUrl('')).toEqual('#');
+    });
+});
 
 describe('Unit | Util | Extract Repo Name', () => {
     test('returns proper value with proper input', () => {

diff --git a/src/components/taskDetails/Details.tsx b/src/components/taskDetails/Details.tsx
@@ -2,8 +2,7 @@ import React, { FC } from 'react';
 import setColor from './taskPriorityColors';
 import classNames from './task-details.module.scss';
 import { TaskDetailsProps } from '@/interfaces/taskDetails.type';
-import extractRepoName from '@/utils/extractRepoName';
-import transformGitHubApiUrl from '@/utils/transformGitHubApiUrl';
+import { transformGitHubApiUrl, extractRepoName } from '@/utils/urlTransform';
 
 const Details: FC<TaskDetailsProps> = ({ detailType, value }) => {
     const color = value ? setColor?.[value] : undefined;

diff --git a/src/utils/transformGitHubApiUrl.ts b/src/utils/transformGitHubApiUrl.ts
diff --git a/src/utils/extractRepoName.ts → src/utils/urlTransform.ts b/src/utils/extractRepoName.ts → src/utils/urlTransform.ts
@@ -1,3 +1,13 @@
+function transformGitHubApiUrl(apiUrl?: string) {
+    if (!apiUrl) return '#';
+    const transformedUrl = apiUrl.replace(
+        /https:\/\/api\.github\.com\/repos\//,
+        'https://github.com/'
+    );
+
+    return transformedUrl;
+}
+
 function extractRepoName(issueUrl: string) {
     const match = issueUrl.match(
         /(?:https:\/\/github\.com\/([^/]+)\/([^/]+)\/issues\/(\d+))|(?:https:\/\/api\.github\.com\/repos\/([^/]+)\/([^/]+)\/issues\/(\d+))/
@@ -12,4 +22,4 @@ function extractRepoName(issueUrl: string) {
     return null;
 }
 
-export default extractRepoName;
+export { transformGitHubApiUrl, extractRepoName };