Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove thisArg from non-nativesque operators #878

Closed
benlesh opened this issue Dec 3, 2015 · 4 comments
Closed

Remove thisArg from non-nativesque operators #878

benlesh opened this issue Dec 3, 2015 · 4 comments
Labels
help wanted Issues we wouldn't mind assistance with.
Milestone
Initial Beta

Comments

@benlesh
Copy link
Member

benlesh commented Dec 3, 2015

Per discussion here #787, we will remove the thisArg arguments from all operators that aren't meant to mirror something in native JavaScript.

So really, only map, filter, reduce and forEach should have thisArgs.

Furthermore, the internal bind helper introduces a closure and should probably be removed in favor of using apply or call directly within those operators, or it should be otherwise refactored to not use closures.
@benlesh benlesh added the help wanted Issues we wouldn't mind assistance with. label Dec 3, 2015
@benlesh benlesh mentioned this issue Dec 3, 2015
Closed
@kwonoj kwonoj mentioned this issue Dec 3, 2015
Closed
kwonoj added a commit to kwonoj/rxjs that referenced this issue Dec 3, 2015
@kwonoj
feat(takeWhile): remove thisArg
a91b915 
relates to ReactiveX#878
@kwonoj kwonoj mentioned this issue Dec 3, 2015
Closed
@benjamingr
Copy link
Contributor

+1 I think this is important for consistency.

Just adding that the following also need a thisArg: some find findIndex and every

@kwonoj kwonoj mentioned this issue Dec 4, 2015
Closed
kwonoj added a commit to kwonoj/rxjs that referenced this issue Dec 4, 2015
@kwonoj
feat(takeWhile): remove thisArg
97e0906 
relates to ReactiveX#878
kwonoj added a commit to kwonoj/rxjs that referenced this issue Dec 4, 2015
@kwonoj
feat(takeWhile): remove thisArg
27de080 
relates to ReactiveX#878
kwonoj added a commit that referenced this issue Dec 4, 2015
@kwonoj @benlesh
feat(takeWhile): remove thisArg
b5219a4 
relates to #878
@benlesh benlesh added this to the Initial Beta milestone Dec 8, 2015
kwonoj added a commit to kwonoj/rxjs that referenced this issue Dec 8, 2015
@kwonoj
feat(count): remove thisArg
878a1fd 
relates to ReactiveX#878
@kwonoj kwonoj mentioned this issue Dec 8, 2015
Merged
kwonoj added a commit to kwonoj/rxjs that referenced this issue Dec 8, 2015
@kwonoj
feat(distinctUntilChanged): remove thisArg
bfc52d6 
relates to ReactiveX#878
@kwonoj kwonoj mentioned this issue Dec 8, 2015
Merged
kwonoj added a commit to kwonoj/rxjs that referenced this issue Dec 8, 2015
@kwonoj
feat(finally): remove thisArg
b2b7994 
relates to ReactiveX#878
@kwonoj kwonoj mentioned this issue Dec 8, 2015
Closed
luisgabriel added a commit to luisgabriel/RxJS that referenced this issue Dec 8, 2015
@luisgabriel
feat(single): remove thisArg
7492d66 
Relates to ReactiveX#878.
@luisgabriel luisgabriel mentioned this issue Dec 8, 2015
Closed
kwonoj added a commit that referenced this issue Dec 8, 2015
@kwonoj
feat(finally): remove thisArg
d4b02fc 
relates to #878
benlesh pushed a commit that referenced this issue Dec 8, 2015
@luisgabriel @benlesh
feat(single): remove thisArg
43af805 
Relates to #878.
staltz added a commit to staltz/RxJSNext that referenced this issue Dec 8, 2015
@staltz
docs(count): remove reference to thisArg
8c040a3 
Remove reference to a thisArg argument given to count() operator in its JSDoc.

For issue ReactiveX#878.
@staltz staltz mentioned this issue Dec 8, 2015
Closed
@benlesh benlesh mentioned this issue Dec 8, 2015
Merged
staltz added a commit to staltz/RxJSNext that referenced this issue Dec 8, 2015
@staltz
refactor(KitchenSink): remove thisArg from distinctUntilChanged signa…
7cc3cbd 
…ture

Remove an obsolete thisArg from the signature of distinctUntilChanged in KitchenSink file.

For issue ReactiveX#878.
@staltz staltz mentioned this issue Dec 8, 2015
Closed
@benlesh benlesh closed this as completed in 14ffce6 Dec 8, 2015
kwonoj pushed a commit that referenced this issue Dec 8, 2015
@staltz @kwonoj
docs(count): remove reference to thisArg
1298b57 
Remove reference to a thisArg argument given to count() operator in its JSDoc.

For issue #878.
@benlesh
Copy link
Member Author

benlesh commented Dec 8, 2015

Reopening until #993 is merged.

@benlesh benlesh reopened this Dec 8, 2015
luisgabriel added a commit to luisgabriel/RxJS that referenced this issue Dec 8, 2015
@luisgabriel
feat(reduce): add thisArg parameter
09642b0 
Adds thisArg as second argument to have symmetry with native Array.prototype.reduce().

Related to  ReactiveX#878.
@luisgabriel luisgabriel mentioned this issue Dec 8, 2015
Closed
luisgabriel added a commit to luisgabriel/RxJS that referenced this issue Dec 8, 2015
@luisgabriel
feat(reduce): add thisArg parameter
d0ec7b3 
Adds thisArg as third argument to have symmetry with native Array.prototype.reduce().

Relates to  ReactiveX#878.
luisgabriel added a commit to luisgabriel/RxJS that referenced this issue Dec 8, 2015
@luisgabriel
feat(reduce): add thisArg parameter
ef890a8 
Adds thisArg as third argument to have symmetry with native Array.prototype.reduce().

Relates to ReactiveX#878 and ReactiveX#996.
benlesh pushed a commit that referenced this issue Dec 9, 2015
@staltz @benlesh
refactor(KitchenSink): remove thisArg from distinctUntilChanged signa…
58c4ea9 
…ture

Remove an obsolete thisArg from the signature of distinctUntilChanged in KitchenSink file.

For issue #878.
@benlesh
Copy link
Member Author

benlesh commented Dec 9, 2015

Closed by #993

@benlesh benlesh closed this as completed Dec 9, 2015
@kwonoj kwonoj mentioned this issue Jan 15, 2016
Closed
@kwonoj kwonoj mentioned this issue Sep 28, 2016
Closed
@kwonoj kwonoj mentioned this issue Oct 19, 2016
Closed
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted Issues we wouldn't mind assistance with.
Projects
None yet
Milestone
Initial Beta
Development

No branches or pull requests
2 participants
@benjamingr @benlesh